chrome/browser/safe_browsing/client_side_detection_service_unittest.cc - Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/client_side_detection_host_unittest.cc ('k') | chrome/browser/safe_browsing/download_protection_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

diff --git a/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc b/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

index ca40838f2cb28fb7531dcccf9f0fe2dabb3d819c..59411ccb72a6871c6e060fc1d354238819566dea 100644

--- a/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

+++ b/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

@@ -236,7 +236,7 @@ class ClientSideDetectionServiceTest : public testing::Test {

void SendRequestDone(GURL phishing_url, bool is_phishing) {

ASSERT_EQ(phishing_url, phishing_url_);

is_phishing_ = is_phishing;

- msg_loop_.Quit();

+ msg_loop_.QuitWhenIdle();

}

void SendMalwareRequestDone(GURL original_url, GURL malware_url,

@@ -244,7 +244,7 @@ class ClientSideDetectionServiceTest : public testing::Test {

ASSERT_EQ(phishing_url_, original_url);

confirmed_malware_url_ = malware_url;

is_malware_ = is_malware;

- msg_loop_.Quit();

+ msg_loop_.QuitWhenIdle();

}

scoped_ptr<content::TestBrowserThread> browser_thread_;