chrome/browser/first_run/try_chrome_dialog_view.cc - Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/first_run/try_chrome_dialog_view.cc

Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/external_protocol/external_protocol_handler_unittest.cc ('k') | chrome/browser/geolocation/access_token_store_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/first_run/try_chrome_dialog_view.cc

diff --git a/chrome/browser/first_run/try_chrome_dialog_view.cc b/chrome/browser/first_run/try_chrome_dialog_view.cc

index 47666e6f5b2ed9b6384ba1e742eb90f7b3b0433c..5918776e5ba2851b2a987ef2be3ce7889872de09 100644

--- a/chrome/browser/first_run/try_chrome_dialog_view.cc

+++ b/chrome/browser/first_run/try_chrome_dialog_view.cc

@@ -359,7 +359,7 @@ void TryChromeDialogView::ButtonPressed(views::Button* sender,

}

popup_->Close();

- base::MessageLoop::current()->Quit();

+ base::MessageLoop::current()->QuitWhenIdle();

}

void TryChromeDialogView::LinkClicked(views::Link* source, int event_flags) {