Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Side by Side Diff: chrome/browser/first_run/try_chrome_dialog_view.cc

Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/first_run/try_chrome_dialog_view.h" 5 #include "chrome/browser/first_run/try_chrome_dialog_view.h"
6 6
7 #include <shellapi.h> 7 #include <shellapi.h>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/message_loop/message_loop.h" 10 #include "base/message_loop/message_loop.h"
(...skipping 341 matching lines...) Expand 10 before | Expand all | Expand 10 after
352 else 352 else
353 NOTREACHED() << "Unknown radio button selected"; 353 NOTREACHED() << "Unknown radio button selected";
354 } 354 }
355 355
356 if (make_default_) { 356 if (make_default_) {
357 if ((result_ == TRY_CHROME) && make_default_->checked()) 357 if ((result_ == TRY_CHROME) && make_default_->checked())
358 result_ = TRY_CHROME_AS_DEFAULT; 358 result_ = TRY_CHROME_AS_DEFAULT;
359 } 359 }
360 360
361 popup_->Close(); 361 popup_->Close();
362 base::MessageLoop::current()->Quit(); 362 base::MessageLoop::current()->QuitWhenIdle();
363 } 363 }
364 364
365 void TryChromeDialogView::LinkClicked(views::Link* source, int event_flags) { 365 void TryChromeDialogView::LinkClicked(views::Link* source, int event_flags) {
366 ::ShellExecuteW(NULL, L"open", kHelpCenterUrl, NULL, NULL, SW_SHOW); 366 ::ShellExecuteW(NULL, L"open", kHelpCenterUrl, NULL, NULL, SW_SHOW);
367 } 367 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698