Policy Ui sends correct translations for risk tags.

Policy Ui sends correct translations for risk tags.

Send localized group names to frontend and reuse some strings from
the old WebUi.
(Prerequisite for CL 1371073003)

BUG=134849
Committed: https://crrev.com/07c5e062f2ea6ef0e3b5844f1a11ecb4df4d41f6
Cr-Commit-Position: refs/heads/master@{#362997}

[fhorschig, 2015-10-09 09:04:52]

The CL was (on request) extracted from
https://codereview.chromium.org/1371073003

[fhorschig, 2015-10-09 09:05:44]

fhorschig@chromium.org changed reviewers:
+ cschuet@chromium.org

[fhorschig, 2015-10-09 09:05:45]

Hi Christoph,
would you please have a quick look on this CL?

Cheers,
Friedrich

[fhorschig, 2015-10-09 10:16:55]

On 2015/10/09 09:05:45, fhorschig wrote:
> Hi Christoph,
> would you please have a quick look on this CL?
> 
> Cheers,
> Friedrich

Don't start. Sorry, I forgot a lot of build files.

[fhorschig, 2015-10-09 11:58:14]

Patchset #2 (id:20001) has been deleted

[fhorschig, 2015-10-09 11:58:21]

Patchset #2 (id:40001) has been deleted

[fhorschig, 2015-10-09 12:00:04]

fhorschig@chromium.org changed reviewers:
+ tnagel@chromium.org
- cschuet@chromium.org

[fhorschig, 2015-10-09 12:00:04]

Hi Thiemo,
would you please review this CL?

Cheers,
Friedrich

[fhorschig, 2015-10-09 12:01:03]

fhorschig@chromium.org changed reviewers:
+ stevenjb@chromium.org

[fhorschig, 2015-10-09 12:22:06]

fhorschig@chromium.org changed reviewers:
- stevenjb@chromium.org

[Thiemo Nagel, 2015-10-12 14:55:27]

https://codereview.chromium.org/1395073002/diff/60001/components/policy_strin...
File components/policy_strings.grdp (right):

https://codereview.chromium.org/1395073002/diff/60001/components/policy_strin...
components/policy_strings.grdp:337: <message
name="IDS_POLICY_RISK_TAG_FULL_ADMIN_ACCESS" desc="Indicates that the policy is
obtained from the local OS.">
All descriptions are wrong!

[fhorschig, 2015-10-13 08:58:56]

https://codereview.chromium.org/1395073002/diff/60001/components/policy_strin...
File components/policy_strings.grdp (right):

https://codereview.chromium.org/1395073002/diff/60001/components/policy_strin...
components/policy_strings.grdp:337: <message
name="IDS_POLICY_RISK_TAG_FULL_ADMIN_ACCESS" desc="Indicates that the policy is
obtained from the local OS.">
On 2015/10/12 14:55:27, Thiemo Nagel wrote:
> All descriptions are wrong!

Wow, absolutely. Fixed.

[Dan Beam, 2015-10-13 16:49:22]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2015-10-13 16:49:23]

https://codereview.chromium.org/1395073002/diff/2/chrome/browser/resources/md...
File chrome/browser/resources/md_policy/policy_resources.grd (right):

https://codereview.chromium.org/1395073002/diff/2/chrome/browser/resources/md...
chrome/browser/resources/md_policy/policy_resources.grd:17: type="chrome_html"/>
why are you making a .grd file for 1 HTML file?  why not just put this in
chrome/browser/browser_resources.grd?

[fhorschig, 2015-10-14 14:50:23]

https://codereview.chromium.org/1395073002/diff/2/chrome/browser/resources/md...
File chrome/browser/resources/md_policy/policy_resources.grd (right):

https://codereview.chromium.org/1395073002/diff/2/chrome/browser/resources/md...
chrome/browser/resources/md_policy/policy_resources.grd:17: type="chrome_html"/>
On 2015/10/13 16:49:23, Dan Beam wrote:
> why are you making a .grd file for 1 HTML file?  why not just put this in
> chrome/browser/browser_resources.grd?

Assuming I would not move code into a separate file. In this case, all build
files, the changes in the policy_ui etc. would be introduced in the follow up
CL. And this is exactly where I am coming from. (Someone requested to put all
changes to policy_ui and build files into a separate CL. This is this separate
CL)

[fhorschig, 2015-10-14 18:24:35]

fhorschig@chromium.org changed reviewers:
- tnagel@chromium.org

[Dan Beam, 2015-10-14 20:21:23]

https://codereview.chromium.org/1395073002/diff/2/chrome/browser/resources/md...
File chrome/browser/resources/md_policy/policy_resources.grd (right):

https://codereview.chromium.org/1395073002/diff/2/chrome/browser/resources/md...
chrome/browser/resources/md_policy/policy_resources.grd:17: type="chrome_html"/>
On 2015/10/14 14:50:23, fhorschig wrote:
> On 2015/10/13 16:49:23, Dan Beam wrote:
> > why are you making a .grd file for 1 HTML file?  why not just put this in
> > chrome/browser/browser_resources.grd?
> 
> Assuming I would not move code into a separate file. In this case, all build
> files, the changes in the policy_ui etc. would be introduced in the follow up
> CL. And this is exactly where I am coming from. (Someone requested to put all
> changes to policy_ui and build files into a separate CL. This is this separate
> CL)

I have no idea what this means

[fhorschig, 2015-10-14 20:53:44]

https://codereview.chromium.org/1395073002/diff/2/chrome/browser/resources/md...
File chrome/browser/resources/md_policy/policy_resources.grd (right):

https://codereview.chromium.org/1395073002/diff/2/chrome/browser/resources/md...
chrome/browser/resources/md_policy/policy_resources.grd:17: type="chrome_html"/>
On 2015/10/14 20:21:22, Dan Beam wrote:
> On 2015/10/14 14:50:23, fhorschig wrote:
> > On 2015/10/13 16:49:23, Dan Beam wrote:
> > > why are you making a .grd file for 1 HTML file?  why not just put this in
> > > chrome/browser/browser_resources.grd?
> > 
> > Assuming I would not move code into a separate file. In this case, all build
> > files, the changes in the policy_ui etc. would be introduced in the follow
up
> > CL. And this is exactly where I am coming from. (Someone requested to put
all
> > changes to policy_ui and build files into a separate CL. This is this
separate
> > CL)
> 
> I have no idea what this means

Sorry, the text is overly complicated. I _will_ need a lot of files in policy
resources grid [1]. The only file that is currently in there, _was_ already in
the browser_resources.grd [2]. The whole point of this CL is to introduce the
build files for this structure (so we don't have it merged with the other CL).
If you would like me to merge the two CLs, I can do so. But we already had a
point where both CLs were merged and someone proposed to separate them.

In case this still makes no sense, I will look up with whom I discussed this
earlier and ask if I misunderstood his intention.

[1] https://codereview.chromium.org/1371073003/patch/460001/470008
[2] https://codereview.chromium.org/1395073002/patch/2/80003

[Dan Beam, 2015-10-14 21:00:40]

https://codereview.chromium.org/1395073002/diff/2/chrome/browser/ui/webui/pol...
File chrome/browser/ui/webui/policy_ui.cc (right):

https://codereview.chromium.org/1395073002/diff/2/chrome/browser/ui/webui/pol...
chrome/browser/ui/webui/policy_ui.cc:8: #include <string.h>
#include <string> (drop the .h)

https://codereview.chromium.org/1395073002/diff/2/chrome/browser/ui/webui/pol...
chrome/browser/ui/webui/policy_ui.cc:108: {"googleSharing",
IDS_POLICY_RISK_TAG_GOOGLE_SHARING}
nit: alphabetize these, also don't omit trailing commas (IMO)

https://codereview.chromium.org/1395073002/diff/2/chrome/browser/ui/webui/pol...
chrome/browser/ui/webui/policy_ui.cc:486: class PolicyMaterialDesignUIHandler :
public PolicyUIHandler {
why is this class not in it's own file[s]?

[Dan Beam, 2015-10-14 21:01:30]

https://codereview.chromium.org/1395073002/diff/2/chrome/browser/resources/md...
File chrome/browser/resources/md_policy/policy_resources.grd (right):

https://codereview.chromium.org/1395073002/diff/2/chrome/browser/resources/md...
chrome/browser/resources/md_policy/policy_resources.grd:17: type="chrome_html"/>
On 2015/10/14 20:53:44, fhorschig wrote:
> On 2015/10/14 20:21:22, Dan Beam wrote:
> > On 2015/10/14 14:50:23, fhorschig wrote:
> > > On 2015/10/13 16:49:23, Dan Beam wrote:
> > > > why are you making a .grd file for 1 HTML file?  why not just put this
in
> > > > chrome/browser/browser_resources.grd?
> > > 
> > > Assuming I would not move code into a separate file. In this case, all
build
> > > files, the changes in the policy_ui etc. would be introduced in the follow
> up
> > > CL. And this is exactly where I am coming from. (Someone requested to put
> all
> > > changes to policy_ui and build files into a separate CL. This is this
> separate
> > > CL)
> > 
> > I have no idea what this means
> 
> Sorry, the text is overly complicated. I _will_ need a lot of files in policy
> resources grid [1]. The only file that is currently in there, _was_ already in
> the browser_resources.grd [2]. The whole point of this CL is to introduce the
> build files for this structure (so we don't have it merged with the other CL).
> If you would like me to merge the two CLs, I can do so. But we already had a
> point where both CLs were merged and someone proposed to separate them.
> 
> In case this still makes no sense, I will look up with whom I discussed this
> earlier and ask if I misunderstood his intention.
> 
> [1] https://codereview.chromium.org/1371073003/patch/460001/470008
> [2] https://codereview.chromium.org/1395073002/patch/2/80003

makes sense but I had no way of knowing there'd be a lot more in this file

TODO(fhorschig): move other resources here

would've been a good clue ;)

[fhorschig, 2015-10-15 14:45:38]

https://codereview.chromium.org/1395073002/diff/2/chrome/browser/resources/md...
File chrome/browser/resources/md_policy/policy_resources.grd (right):

https://codereview.chromium.org/1395073002/diff/2/chrome/browser/resources/md...
chrome/browser/resources/md_policy/policy_resources.grd:17: type="chrome_html"/>
On 2015/10/14 21:01:29, Dan Beam wrote:
> On 2015/10/14 20:53:44, fhorschig wrote:
> > On 2015/10/14 20:21:22, Dan Beam wrote:
> > > On 2015/10/14 14:50:23, fhorschig wrote:
> > > > On 2015/10/13 16:49:23, Dan Beam wrote:
> > > > > why are you making a .grd file for 1 HTML file?  why not just put this
> in
> > > > > chrome/browser/browser_resources.grd?
> > > > 
> > > > Assuming I would not move code into a separate file. In this case, all
> build
> > > > files, the changes in the policy_ui etc. would be introduced in the
follow
> > up
> > > > CL. And this is exactly where I am coming from. (Someone requested to
put
> > all
> > > > changes to policy_ui and build files into a separate CL. This is this
> > separate
> > > > CL)
> > > 
> > > I have no idea what this means
> > 
> > Sorry, the text is overly complicated. I _will_ need a lot of files in
policy
> > resources grid [1]. The only file that is currently in there, _was_ already
in
> > the browser_resources.grd [2]. The whole point of this CL is to introduce
the
> > build files for this structure (so we don't have it merged with the other
CL).
> > If you would like me to merge the two CLs, I can do so. But we already had a
> > point where both CLs were merged and someone proposed to separate them.
> > 
> > In case this still makes no sense, I will look up with whom I discussed this
> > earlier and ask if I misunderstood his intention.
> > 
> > [1] https://codereview.chromium.org/1371073003/patch/460001/470008
> > [2] https://codereview.chromium.org/1395073002/patch/2/80003
> 
> makes sense but I had no way of knowing there'd be a lot more in this file
> 
> TODO(fhorschig): move other resources here
> 
> would've been a good clue ;)

TODO is a nice idea. Added one and kept this in mind for later CLs.

https://codereview.chromium.org/1395073002/diff/2/chrome/browser/ui/webui/pol...
File chrome/browser/ui/webui/policy_ui.cc (right):

https://codereview.chromium.org/1395073002/diff/2/chrome/browser/ui/webui/pol...
chrome/browser/ui/webui/policy_ui.cc:8: #include <string.h>
On 2015/10/14 21:00:40, Dan Beam wrote:
> #include <string> (drop the .h)

Done.

https://codereview.chromium.org/1395073002/diff/2/chrome/browser/ui/webui/pol...
chrome/browser/ui/webui/policy_ui.cc:108: {"googleSharing",
IDS_POLICY_RISK_TAG_GOOGLE_SHARING}
On 2015/10/14 21:00:40, Dan Beam wrote:
> nit: alphabetize these, also don't omit trailing commas (IMO)
Trailing comma added. Added a comment that the order relies the enum values and
should not be sorted otherwise.

https://codereview.chromium.org/1395073002/diff/2/chrome/browser/ui/webui/pol...
chrome/browser/ui/webui/policy_ui.cc:486: class PolicyMaterialDesignUIHandler :
public PolicyUIHandler {
On 2015/10/14 21:00:40, Dan Beam wrote:
> why is this class not in it's own file[s]?

A justified question. It seems to be usual to have declaration and
implementation of simpler UiHandlers within a single file. I would propose to
apply this refactoring in case the PolicyMaterialDesignUiHandler gets more
complex. Currently, I wouldn't see enough benefit to do so (mainly because of
shared functionality).

[Dan Beam, 2015-10-15 16:55:03]

https://codereview.chromium.org/1395073002/diff/2/chrome/browser/ui/webui/pol...
File chrome/browser/ui/webui/policy_ui.cc (right):

https://codereview.chromium.org/1395073002/diff/2/chrome/browser/ui/webui/pol...
chrome/browser/ui/webui/policy_ui.cc:486: class PolicyMaterialDesignUIHandler :
public PolicyUIHandler {
On 2015/10/15 14:45:38, fhorschig wrote:
> On 2015/10/14 21:00:40, Dan Beam wrote:
> > why is this class not in it's own file[s]?
> 
> A justified question. It seems to be usual to have declaration and
> implementation of simpler UiHandlers within a single file. I would propose to
> apply this refactoring in case the PolicyMaterialDesignUiHandler gets more
> complex. Currently, I wouldn't see enough benefit to do so (mainly because of
> shared functionality).

it seems far more "usual" to have 1 class per file

[fhorschig, 2015-10-22 14:33:43]

Patchset #5 (id:110001) has been deleted

[fhorschig, 2015-10-22 14:47:08]

CC'ed tnagel

https://codereview.chromium.org/1395073002/diff/2/chrome/browser/ui/webui/pol...
File chrome/browser/ui/webui/policy_ui.cc (right):

https://codereview.chromium.org/1395073002/diff/2/chrome/browser/ui/webui/pol...
chrome/browser/ui/webui/policy_ui.cc:486: class PolicyMaterialDesignUIHandler :
public PolicyUIHandler {
On 2015/10/15 16:55:03, Dan Beam wrote:
> On 2015/10/15 14:45:38, fhorschig wrote:
> > On 2015/10/14 21:00:40, Dan Beam wrote:
> > > why is this class not in it's own file[s]?
> > 
> > A justified question. It seems to be usual to have declaration and
> > implementation of simpler UiHandlers within a single file. I would propose
to
> > apply this refactoring in case the PolicyMaterialDesignUiHandler gets more
> > complex. Currently, I wouldn't see enough benefit to do so (mainly because
of
> > shared functionality).
> 
> it seems far more "usual" to have 1 class per file

There is now a separate class for PolicyMaterialDesignUi and the
PolicyUiHandler. The latter one contains shared information, so it makes sense
to put it into a separate file. As most other WebUi children do, the
implementation of the handler (which doesn't share any information) is still
defined and implemented in the source file.

This should make the code much more cleaner but if you would prefer to create
even more separate files, please mention it and I will have another look into
this. I am not entirely sure how the threshold of "too many files versus too
huge files" is set for this project. (Also it reduces the potential pollution of
the global namespace to have handlers and ui in separate files ... so I am
really not sure.)

[Thiemo Nagel, 2015-11-03 17:56:54]

Dan, may I kindly ask you to take another look?

Many thanks,
Thiemo

[Dan Beam, 2015-11-03 18:34:11]

lgtm w/nits

https://codereview.chromium.org/1395073002/diff/130001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/policy_material_design_ui.cc (right):

https://codereview.chromium.org/1395073002/diff/130001/chrome/browser/ui/webu...
chrome/browser/ui/webui/policy_material_design_ui.cc:1: // Copyright (c) 2012
The Chromium Authors. All rights reserved.
(c) 2012 -> 2015

https://codereview.chromium.org/1395073002/diff/130001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/policy_material_design_ui.h (right):

https://codereview.chromium.org/1395073002/diff/130001/chrome/browser/ui/webu...
chrome/browser/ui/webui/policy_material_design_ui.h:1: // Copyright (c) 2012 The
Chromium Authors. All rights reserved.
(c) 2012 -> 2015

https://codereview.chromium.org/1395073002/diff/130001/chrome/browser/ui/webu...
chrome/browser/ui/webui/policy_material_design_ui.h:8: #include
"base/basictypes.h"
^ remove

https://codereview.chromium.org/1395073002/diff/130001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/policy_ui_handler.cc (right):

https://codereview.chromium.org/1395073002/diff/130001/chrome/browser/ui/webu...
chrome/browser/ui/webui/policy_ui_handler.cc:8: #include <string.h>
just include <string> in policy_ui_handler.h and remove this

https://codereview.chromium.org/1395073002/diff/130001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/policy_ui_handler.h (right):

https://codereview.chromium.org/1395073002/diff/130001/chrome/browser/ui/webu...
chrome/browser/ui/webui/policy_ui_handler.h:6: #define
CHROME_BROWSER_UI_WEBUI_POLICY_UI_HANDLER_H_

#include <string>

https://codereview.chromium.org/1395073002/diff/130001/chrome/browser/ui/webu...
chrome/browser/ui/webui/policy_ui_handler.h:8: #include "base/macros.h"
#include "base/memory/scoped_ptr.h"
#include "base/memory/weak_ptr.h"

[fhorschig, 2015-11-04 18:51:18]

https://codereview.chromium.org/1395073002/diff/130001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/policy_material_design_ui.cc (right):

https://codereview.chromium.org/1395073002/diff/130001/chrome/browser/ui/webu...
chrome/browser/ui/webui/policy_material_design_ui.cc:1: // Copyright (c) 2012
The Chromium Authors. All rights reserved.
On 2015/11/03 18:34:10, Dan Beam wrote:
> (c) 2012 -> 2015

Done.

https://codereview.chromium.org/1395073002/diff/130001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/policy_material_design_ui.h (right):

https://codereview.chromium.org/1395073002/diff/130001/chrome/browser/ui/webu...
chrome/browser/ui/webui/policy_material_design_ui.h:1: // Copyright (c) 2012 The
Chromium Authors. All rights reserved.
On 2015/11/03 18:34:10, Dan Beam wrote:
> (c) 2012 -> 2015

Done.

https://codereview.chromium.org/1395073002/diff/130001/chrome/browser/ui/webu...
chrome/browser/ui/webui/policy_material_design_ui.h:8: #include
"base/basictypes.h"
On 2015/11/03 18:34:10, Dan Beam wrote:
> ^ remove

Done.

https://codereview.chromium.org/1395073002/diff/130001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/policy_ui_handler.cc (right):

https://codereview.chromium.org/1395073002/diff/130001/chrome/browser/ui/webu...
chrome/browser/ui/webui/policy_ui_handler.cc:8: #include <string.h>
On 2015/11/03 18:34:11, Dan Beam wrote:
> just include <string> in policy_ui_handler.h and remove this

Done.

https://codereview.chromium.org/1395073002/diff/130001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/policy_ui_handler.h (right):

https://codereview.chromium.org/1395073002/diff/130001/chrome/browser/ui/webu...
chrome/browser/ui/webui/policy_ui_handler.h:6: #define
CHROME_BROWSER_UI_WEBUI_POLICY_UI_HANDLER_H_
On 2015/11/03 18:34:11, Dan Beam wrote:
> 
> #include <string>

Done.

https://codereview.chromium.org/1395073002/diff/130001/chrome/browser/ui/webu...
chrome/browser/ui/webui/policy_ui_handler.h:8: #include "base/macros.h"
On 2015/11/03 18:34:11, Dan Beam wrote:
> #include "base/memory/scoped_ptr.h"
> #include "base/memory/weak_ptr.h"

Done.

[fhorschig, 2015-11-04 19:01:22]

fhorschig@chromium.org changed reviewers:
+ jhawkins@chromium.org

[fhorschig, 2015-11-04 19:01:22]

jhawkins@chromium.org: Would you please have a look into chrome/BUILD.gn and
chrome/chrome_resources.gyp ?

[fhorschig, 2015-11-04 19:02:55]

fhorschig@chromium.org changed reviewers:
+ cschuet@chromium.org

[fhorschig, 2015-11-04 19:02:55]

cschuet@chromium.org: Hi Christoph, would you please have a look into
components/policy_strings.grdp?

[cschuet (SLOW), 2015-11-04 20:41:54]

components/policy_strings.grdp LGTM with nits

https://codereview.chromium.org/1395073002/diff/150001/components/policy_stri...
File components/policy_strings.grdp (right):

https://codereview.chromium.org/1395073002/diff/150001/components/policy_stri...
components/policy_strings.grdp:337: <message
name="IDS_POLICY_RISK_TAG_FULL_ADMIN_ACCESS" desc="Title of a group/tag whose
policies potientially allow the administrator to access all of a users data.">
nit: user's

https://codereview.chromium.org/1395073002/diff/150001/components/policy_stri...
components/policy_strings.grdp:337: <message
name="IDS_POLICY_RISK_TAG_FULL_ADMIN_ACCESS" desc="Title of a group/tag whose
policies potientially allow the administrator to access all of a users data.">
nit: potentially

[James Hawkins, 2015-11-05 01:34:06]

Hey fhorschig, you should probably find another top-level OWNER.  I'm at a
summit this week, but more importantly, I'm probably going to remove myself from
Chrome OWNERS when I get back next week.

[Thiemo Nagel, 2015-11-05 12:35:57]

On 2015/11/05 01:34:06, James Hawkins wrote:
> Hey fhorschig, you should probably find another top-level OWNER.  I'm at a
> summit this week, but more importantly, I'm probably going to remove myself
from
> Chrome OWNERS when I get back next week.

Thanks for the heads-up, James.

[Thiemo Nagel, 2015-11-05 12:36:09]

tnagel@chromium.org changed reviewers:
- jhawkins@chromium.org

[Thiemo Nagel, 2015-11-05 12:41:26]

tnagel@chromium.org changed reviewers:
+ brettw@chromium.org, tnagel@chromium.org

[Thiemo Nagel, 2015-11-05 12:41:27]

Hi Brett,

may I ask you to take a look at

chrome/BUILD.gn
chrome/chrome_resources.gyp ?

Thank you,
Thiemo

[fhorschig, 2015-11-09 16:45:10]

Patchset #7 (id:170001) has been deleted

[fhorschig, 2015-11-09 16:45:28]

https://codereview.chromium.org/1395073002/diff/150001/components/policy_stri...
File components/policy_strings.grdp (right):

https://codereview.chromium.org/1395073002/diff/150001/components/policy_stri...
components/policy_strings.grdp:337: <message
name="IDS_POLICY_RISK_TAG_FULL_ADMIN_ACCESS" desc="Title of a group/tag whose
policies potientially allow the administrator to access all of a users data.">
On 2015/11/04 20:41:54, cschuet wrote:
> nit: potentially

Done.

https://codereview.chromium.org/1395073002/diff/150001/components/policy_stri...
components/policy_strings.grdp:337: <message
name="IDS_POLICY_RISK_TAG_FULL_ADMIN_ACCESS" desc="Title of a group/tag whose
policies potientially allow the administrator to access all of a users data.">
On 2015/11/04 20:41:54, cschuet wrote:
> nit: user's

Done.

[fhorschig, 2015-11-21 10:51:42]

On 2015/11/09 16:45:28, fhorschig wrote:
>
https://codereview.chromium.org/1395073002/diff/150001/components/policy_stri...
> File components/policy_strings.grdp (right):
> 
>
https://codereview.chromium.org/1395073002/diff/150001/components/policy_stri...
> components/policy_strings.grdp:337: <message
> name="IDS_POLICY_RISK_TAG_FULL_ADMIN_ACCESS" desc="Title of a group/tag whose
> policies potientially allow the administrator to access all of a users data.">
> On 2015/11/04 20:41:54, cschuet wrote:
> > nit: potentially
> 
> Done.
> 
>
https://codereview.chromium.org/1395073002/diff/150001/components/policy_stri...
> components/policy_strings.grdp:337: <message
> name="IDS_POLICY_RISK_TAG_FULL_ADMIN_ACCESS" desc="Title of a group/tag whose
> policies potientially allow the administrator to access all of a users data.">
> On 2015/11/04 20:41:54, cschuet wrote:
> > nit: user's
> 
> Done.

Hi Brett,

friendly ping for the mentioned build files. Shouldn't cause much trouble ;)

Cheers,
Friedrich

[brettw, 2015-11-25 21:08:38]

lgtm

[fhorschig, 2015-12-03 15:08:24]

The CQ bit was checked by fhorschig@chromium.org

[fhorschig, 2015-12-03 15:08:24]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org,
cschuet@chromium.org
Link to the patchset: https://codereview.chromium.org/1395073002/#ps190001
(title: "Description corrected.")

[commit-bot: I haz the power, 2015-12-03 15:08:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1395073002/190001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1395073002/190001

[commit-bot: I haz the power, 2015-12-03 15:08:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-03 15:08:57]

The author fhorschig@chromium.org has not signed Google Contributor License
Agreement. Please visit https://cla.developers.google.com to sign and manage
CLA.

[fhorschig, 2015-12-03 15:15:33]

The CQ bit was checked by fhorschig@chromium.org

[commit-bot: I haz the power, 2015-12-03 15:16:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1395073002/190001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1395073002/190001

[commit-bot: I haz the power, 2015-12-03 16:49:04]

Description was changed from

==========
Policy Ui sends correct translations for risk tags.

Send localized group names to frontend and reuse some strings from
the old WebUi.
(Prerequisite for CL 1371073003)

BUG=134849
==========

to

==========
Policy Ui sends correct translations for risk tags.

Send localized group names to frontend and reuse some strings from
the old WebUi.
(Prerequisite for CL 1371073003)

BUG=134849
==========

[commit-bot: I haz the power, 2015-12-03 16:49:05]

Committed patchset #7 (id:190001)

[commit-bot: I haz the power, 2015-12-03 16:50:50]

Description was changed from

==========
Policy Ui sends correct translations for risk tags.

Send localized group names to frontend and reuse some strings from
the old WebUi.
(Prerequisite for CL 1371073003)

BUG=134849
==========

to

==========
Policy Ui sends correct translations for risk tags.

Send localized group names to frontend and reuse some strings from
the old WebUi.
(Prerequisite for CL 1371073003)

BUG=134849

Committed: https://crrev.com/07c5e062f2ea6ef0e3b5844f1a11ecb4df4d41f6
Cr-Commit-Position: refs/heads/master@{#362997}
==========

[commit-bot: I haz the power, 2015-12-03 16:50:51]

Patchset 7 (id:??) landed as
https://crrev.com/07c5e062f2ea6ef0e3b5844f1a11ecb4df4d41f6
Cr-Commit-Position: refs/heads/master@{#362997}

[Thiemo Nagel, 2015-12-03 16:59:38]

On 2015/12/03 15:08:57, commit-bot: I haz the power wrote:
> The author mailto:fhorschig@chromium.org has not signed Google Contributor
License
> Agreement. Please visit https://cla.developers.google.com to sign and manage
> CLA.

Friedrich, could you please be so kind to sign the CLA for your contributions
in-between contracts?  ;)

[fhorschig, 2015-12-03 19:24:24]

On 2015/12/03 16:59:38, Thiemo Nagel wrote:
> On 2015/12/03 15:08:57, commit-bot: I haz the power wrote:
> > The author mailto:fhorschig@chromium.org has not signed Google Contributor
> License
> > Agreement. Please visit https://cla.developers.google.com to sign and manage
> > CLA.
> 
> Friedrich, could you please be so kind to sign the CLA for your contributions
> in-between contracts?  ;)

Okay, I did. (Or at least, I think I did ... by typing my data into the linked
form.)

[fhorschig, 2015-12-03 19:24:29]

On 2015/12/03 16:59:38, Thiemo Nagel wrote:
> On 2015/12/03 15:08:57, commit-bot: I haz the power wrote:
> > The author mailto:fhorschig@chromium.org has not signed Google Contributor
> License
> > Agreement. Please visit https://cla.developers.google.com to sign and manage
> > CLA.
> 
> Friedrich, could you please be so kind to sign the CLA for your contributions
> in-between contracts?  ;)

Okay, I did. (Or at least, I think I did ... by typing my data into the linked
form.)