chrome/browser/resources/md_policy/policy_resources.grd - Issue 1395073002: Policy Ui sends correct translations for risk tags.

Side by Side Diff: chrome/browser/resources/md_policy/policy_resources.grd

Issue 1395073002: Policy Ui sends correct translations for risk tags. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Translation descriptions added. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="UTF-8"?>

	2 <grit latest_public_release="0" current_release="1">

	3 <outputs>

	4 <output filename="grit/policy_resources.h" type="rc_header">

	5 <emit emit_type='prepend'></emit>

	6 </output>

	7 <output filename="grit/policy_resources_map.cc"

	8 type="resource_file_map_source" />

	9 <output filename="grit/policy_resources_map.h"

	10 type="resource_map_header" />

	11 <output filename="policy_resources.pak" type="data_package" />

	12 </outputs>

	13 <release seq="1">

	14 <structures>

	15 <structure name="IDR_MD_POLICY_HTML"

	16 file="md_policy.html"

	17 type="chrome_html"/>
	Dan Beam 2015/10/13 16:49:23 why are you making a .grd file for 1 HTML file? w why are you making a .grd file for 1 HTML file? why not just put this in chrome/browser/browser_resources.grd? fhorschig 2015/10/14 14:50:23 Assuming I would not move code into a separate fil Show quoted text On 2015/10/13 16:49:23, Dan Beam wrote: > why are you making a .grd file for 1 HTML file? why not just put this in > chrome/browser/browser_resources.grd? Assuming I would not move code into a separate file. In this case, all build files, the changes in the policy_ui etc. would be introduced in the follow up CL. And this is exactly where I am coming from. (Someone requested to put all changes to policy_ui and build files into a separate CL. This is this separate CL) Dan Beam 2015/10/14 20:21:22 I have no idea what this means Show quoted text On 2015/10/14 14:50:23, fhorschig wrote: > On 2015/10/13 16:49:23, Dan Beam wrote: > > why are you making a .grd file for 1 HTML file? why not just put this in > > chrome/browser/browser_resources.grd? > > Assuming I would not move code into a separate file. In this case, all build > files, the changes in the policy_ui etc. would be introduced in the follow up > CL. And this is exactly where I am coming from. (Someone requested to put all > changes to policy_ui and build files into a separate CL. This is this separate > CL) I have no idea what this means fhorschig 2015/10/14 20:53:44 Sorry, the text is overly complicated. I _will_ ne Show quoted text On 2015/10/14 20:21:22, Dan Beam wrote: > On 2015/10/14 14:50:23, fhorschig wrote: > > On 2015/10/13 16:49:23, Dan Beam wrote: > > > why are you making a .grd file for 1 HTML file? why not just put this in > > > chrome/browser/browser_resources.grd? > > > > Assuming I would not move code into a separate file. In this case, all build > > files, the changes in the policy_ui etc. would be introduced in the follow up > > CL. And this is exactly where I am coming from. (Someone requested to put all > > changes to policy_ui and build files into a separate CL. This is this separate > > CL) > > I have no idea what this means Sorry, the text is overly complicated. I _will_ need a lot of files in policy resources grid [1]. The only file that is currently in there, _was_ already in the browser_resources.grd [2]. The whole point of this CL is to introduce the build files for this structure (so we don't have it merged with the other CL). If you would like me to merge the two CLs, I can do so. But we already had a point where both CLs were merged and someone proposed to separate them. In case this still makes no sense, I will look up with whom I discussed this earlier and ask if I misunderstood his intention. [1] https://codereview.chromium.org/1371073003/patch/460001/470008 [2] https://codereview.chromium.org/1395073002/patch/2/80003 Dan Beam 2015/10/14 21:01:29 makes sense but I had no way of knowing there'd be Show quoted text On 2015/10/14 20:53:44, fhorschig wrote: > On 2015/10/14 20:21:22, Dan Beam wrote: > > On 2015/10/14 14:50:23, fhorschig wrote: > > > On 2015/10/13 16:49:23, Dan Beam wrote: > > > > why are you making a .grd file for 1 HTML file? why not just put this in > > > > chrome/browser/browser_resources.grd? > > > > > > Assuming I would not move code into a separate file. In this case, all build > > > files, the changes in the policy_ui etc. would be introduced in the follow > up > > > CL. And this is exactly where I am coming from. (Someone requested to put > all > > > changes to policy_ui and build files into a separate CL. This is this > separate > > > CL) > > > > I have no idea what this means > > Sorry, the text is overly complicated. I _will_ need a lot of files in policy > resources grid [1]. The only file that is currently in there, _was_ already in > the browser_resources.grd [2]. The whole point of this CL is to introduce the > build files for this structure (so we don't have it merged with the other CL). > If you would like me to merge the two CLs, I can do so. But we already had a > point where both CLs were merged and someone proposed to separate them. > > In case this still makes no sense, I will look up with whom I discussed this > earlier and ask if I misunderstood his intention. > > [1] https://codereview.chromium.org/1371073003/patch/460001/470008 > [2] https://codereview.chromium.org/1395073002/patch/2/80003 makes sense but I had no way of knowing there'd be a lot more in this file TODO(fhorschig): move other resources here would've been a good clue ;) fhorschig 2015/10/15 14:45:38 TODO is a nice idea. Added one and kept this in mi Show quoted text On 2015/10/14 21:01:29, Dan Beam wrote: > On 2015/10/14 20:53:44, fhorschig wrote: > > On 2015/10/14 20:21:22, Dan Beam wrote: > > > On 2015/10/14 14:50:23, fhorschig wrote: > > > > On 2015/10/13 16:49:23, Dan Beam wrote: > > > > > why are you making a .grd file for 1 HTML file? why not just put this > in > > > > > chrome/browser/browser_resources.grd? > > > > > > > > Assuming I would not move code into a separate file. In this case, all > build > > > > files, the changes in the policy_ui etc. would be introduced in the follow > > up > > > > CL. And this is exactly where I am coming from. (Someone requested to put > > all > > > > changes to policy_ui and build files into a separate CL. This is this > > separate > > > > CL) > > > > > > I have no idea what this means > > > > Sorry, the text is overly complicated. I _will_ need a lot of files in policy > > resources grid [1]. The only file that is currently in there, _was_ already in > > the browser_resources.grd [2]. The whole point of this CL is to introduce the > > build files for this structure (so we don't have it merged with the other CL). > > If you would like me to merge the two CLs, I can do so. But we already had a > > point where both CLs were merged and someone proposed to separate them. > > > > In case this still makes no sense, I will look up with whom I discussed this > > earlier and ask if I misunderstood his intention. > > > > [1] https://codereview.chromium.org/1371073003/patch/460001/470008 > > [2] https://codereview.chromium.org/1395073002/patch/2/80003 > > makes sense but I had no way of knowing there'd be a lot more in this file > > TODO(fhorschig): move other resources here > > would've been a good clue ;) TODO is a nice idea. Added one and kept this in mind for later CLs.
	18 </structures>

	19 </release>

	20 </grit>

OLD	NEW

« no previous file with comments | « chrome/browser/resources/BUILD.gn ('k') | chrome/browser/ui/webui/policy_ui.cc » ('j') | chrome/browser/ui/webui/policy_ui.cc » ('J')