Issue 139503006: A64: Implement pre-aging support for A64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 139503006: A64: Implement pre-aging support for A64. (Closed)

Created:
6 years, 10 months ago by rmcilroy

Modified:
6 years, 10 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
v8-dev, Rodolph Perfetta (ARM)

Base URL:
https://v8.googlecode.com/svn/branches/experimental/a64

Visibility:
Public.

More Reviews

Description

A64: Implement pre-aging support for A64. R=jochen@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19218

Patch Set 2 : Address comments. #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -9 lines)			Patch
M	src/a64/builtins-a64.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/a64/macro-assembler-a64.h	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download
M	src/a64/macro-assembler-a64.cc	View	1	3 chunks	+15 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

https://codereview.chromium.org/139503006/diff/1/src/a64/macro-assembler-a64.cc File src/a64/macro-assembler-a64.cc (right): https://codereview.chromium.org/139503006/diff/1/src/a64/macro-assembler-a64.cc#newcode2599 src/a64/macro-assembler-a64.cc:2599: EmitCodeAgeSequence(this, stub); should this be EmitCodeAgeSequence(stub)?

6 years, 10 months ago (2014-02-10 09:27:43 UTC) #2

rmcilroy

Thanks! https://codereview.chromium.org/139503006/diff/1/src/a64/macro-assembler-a64.cc File src/a64/macro-assembler-a64.cc (right): https://codereview.chromium.org/139503006/diff/1/src/a64/macro-assembler-a64.cc#newcode2599 src/a64/macro-assembler-a64.cc:2599: EmitCodeAgeSequence(this, stub); On 2014/02/10 09:27:43, jochen wrote: > ...

6 years, 10 months ago (2014-02-10 10:16:01 UTC) #3

rmcilroy

6 years, 10 months ago (2014-02-10 10:23:54 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r19218 (presubmit successful).

Expand Messages | Collapse Messages

Issue 139503006: A64: Implement pre-aging support for A64. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address comments. #

Messages