Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 1395013003: Remove build/module_args/dart.gni (Closed)

Created:
5 years, 2 months ago by Dirk Pranke
Modified:
5 years, 2 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove build/module_args/dart.gni Now that we're no longer rolling mojo into chrome, we no longer need to worry about keeping around a reference to an empty dart.gni file. R=rockot@chromium.org BUG= Committed: https://crrev.com/71a32a6f3f77e5ceb2022087ad7b1aea726fcbf2 Cr-Commit-Position: refs/heads/master@{#353466}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
D build/module_args/dart.gni View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/mojo/src/mojo/public/mojo.gni View 1 chunk +0 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (3 generated)
Dirk Pranke
5 years, 2 months ago (2015-10-09 22:23:29 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1395013003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1395013003/1
5 years, 2 months ago (2015-10-09 22:25:08 UTC) #3
Ken Rockot(use gerrit already)
lgtm
5 years, 2 months ago (2015-10-09 22:25:21 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-10 00:21:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1395013003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1395013003/1
5 years, 2 months ago (2015-10-10 18:32:19 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-10 18:38:47 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-10 18:39:45 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/71a32a6f3f77e5ceb2022087ad7b1aea726fcbf2
Cr-Commit-Position: refs/heads/master@{#353466}

Powered by Google App Engine
This is Rietveld 408576698