Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Issue 1390063006: Remove //build/module_args/mojo.gni. (Closed)

Created:
5 years, 2 months ago by Dirk Pranke
Modified:
5 years, 2 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, plundblad+watch_chromium.org, viettrungluu+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, yuzo+watch_chromium.org, Aaron Boodman, je_julie, dcheng, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove_dart_module_args
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove //build/module_args/mojo.gni. Now that we're no longer rolling Mojo into Chromium, we can simplify all of the mojo and mojo-using build files to just use the settings that are appropriate for Chromium. The first step in this is to remove the module_args file and merge //third_party/mojo/src/mojo/public.gni into //mojo/public/mojo.gni. A follow-on CL will actually remove the use of the variables that are still defined in //mojo/public/mojo.gni and get rid of that file too. R=rockot@chromium.org, jam@chromium.org BUG= Committed: https://crrev.com/36013a053149bf7196c1a5b9e0682945c7a56a5a Cr-Commit-Position: refs/heads/master@{#353618}

Patch Set 1 #

Patch Set 2 : merge to head #

Patch Set 3 : fix a few relative imports #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -145 lines) Patch
D build/module_args/mojo.gni View 1 chunk +0 lines, -42 lines 0 comments Download
M components/web_view/public/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/test/BUILD.gn View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/mojo.gni View 1 chunk +6 lines, -33 lines 0 comments Download
M mojo/services/updater/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/edk/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/tests/BUILD.gn View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/java/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
D third_party/mojo/src/mojo/public/mojo.gni View 1 chunk +0 lines, -57 lines 0 comments Download
M third_party/mojo/src/mojo/public/mojo_application.gni View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/mojo_services/src/accessibility/public/interfaces/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/mojo_services/src/clipboard/public/interfaces/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 21 (9 generated)
Dirk Pranke
5 years, 2 months ago (2015-10-09 23:30:18 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1390063006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1390063006/1
5 years, 2 months ago (2015-10-09 23:30:55 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/79831) ios_rel_device_ninja on ...
5 years, 2 months ago (2015-10-09 23:39:19 UTC) #5
Ken Rockot(use gerrit already)
lgtm
5 years, 2 months ago (2015-10-12 17:38:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1390063006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1390063006/20001
5 years, 2 months ago (2015-10-12 19:50:03 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/143549)
5 years, 2 months ago (2015-10-12 19:59:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1390063006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1390063006/40001
5 years, 2 months ago (2015-10-12 22:11:00 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/108703)
5 years, 2 months ago (2015-10-12 22:24:07 UTC) #16
jam
lgtm
5 years, 2 months ago (2015-10-12 22:35:34 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1390063006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1390063006/40001
5 years, 2 months ago (2015-10-12 22:41:09 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-12 22:58:22 UTC) #20
commit-bot: I haz the power
5 years, 2 months ago (2015-10-12 22:59:04 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/36013a053149bf7196c1a5b9e0682945c7a56a5a
Cr-Commit-Position: refs/heads/master@{#353618}

Powered by Google App Engine
This is Rietveld 408576698