extensions/browser/extension_icon_image_unittest.cc - Issue 1394993004: Make ValueDeserializer::Deserialize return scoped_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/extension_icon_image_unittest.cc

Issue 1394993004: Make ValueDeserializer::Deserialize return scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix and add todo about not failed trybot Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/printer_provider/printer_provider_api.cc ('k') | extensions/browser/image_loader_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/extension_icon_image_unittest.cc

diff --git a/extensions/browser/extension_icon_image_unittest.cc b/extensions/browser/extension_icon_image_unittest.cc

index 88c2fe41003ce6effb024a37c067658c7c2e97cd..35a8b5c0c5f7252a35e00275c2dfdf29a6638e78 100644

--- a/extensions/browser/extension_icon_image_unittest.cc

+++ b/extensions/browser/extension_icon_image_unittest.cc

@@ -104,9 +104,8 @@ class ExtensionIconImageTest : public ExtensionsTest,

std::string error;

JSONFileValueDeserializer deserializer(

test_file.AppendASCII("manifest.json"));

- scoped_ptr<base::DictionaryValue> valid_value(

- static_cast<base::DictionaryValue*>(

- deserializer.Deserialize(&error_code, &error)));

+ scoped_ptr<base::DictionaryValue> valid_value = base::DictionaryValue::From(

+ deserializer.Deserialize(&error_code, &error));

EXPECT_EQ(0, error_code) << error;

if (error_code != 0)

return NULL;

« no previous file with comments | « extensions/browser/api/printer_provider/printer_provider_api.cc ('k') | extensions/browser/image_loader_unittest.cc » ('j') | no next file with comments »