extensions/browser/api/printer_provider/printer_provider_api.cc - Issue 1394993004: Make ValueDeserializer::Deserialize return scoped_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/printer_provider/printer_provider_api.cc

Issue 1394993004: Make ValueDeserializer::Deserialize return scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix and add todo about not failed trybot Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/api/printer_provider/printer_provider_api.cc

diff --git a/extensions/browser/api/printer_provider/printer_provider_api.cc b/extensions/browser/api/printer_provider/printer_provider_api.cc

index 8b02814d1c0004a88af041bc5839eb46c8979d86..b5d16a8ec66c88033cce1e2d1667dbca9b47ba61 100644

--- a/extensions/browser/api/printer_provider/printer_provider_api.cc

+++ b/extensions/browser/api/printer_provider/printer_provider_api.cc

@@ -594,7 +594,7 @@ void PrinterProviderAPIImpl::DispatchPrintRequested(

print_job.printer_id = internal_printer_id;

JSONStringValueDeserializer deserializer(job.ticket_json);

- scoped_ptr<base::Value> ticket_value(deserializer.Deserialize(NULL, NULL));

+ scoped_ptr<base::Value> ticket_value = deserializer.Deserialize(NULL, NULL);

if (!ticket_value ||

!api::printer_provider::PrintJob::Ticket::Populate(*ticket_value,

&print_job.ticket)) {

« no previous file with comments | « components/update_client/component_unpacker.cc ('k') | extensions/browser/extension_icon_image_unittest.cc » ('j') | no next file with comments »