components/omnibox/browser/search_suggestion_parser.cc - Issue 1394993004: Make ValueDeserializer::Deserialize return scoped_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/omnibox/browser/search_suggestion_parser.cc

Issue 1394993004: Make ValueDeserializer::Deserialize return scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix and add todo about not failed trybot Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/json_schema/json_schema_validator_unittest_base.cc ('k') | components/policy/core/common/config_dir_policy_loader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/omnibox/browser/search_suggestion_parser.cc

diff --git a/components/omnibox/browser/search_suggestion_parser.cc b/components/omnibox/browser/search_suggestion_parser.cc

index 24ab6370806b3c6b890de5032f75736d6ad7dee9..df0e00b3f4123e2ee8af00493c4a7f8fe5c0eac8 100644

--- a/components/omnibox/browser/search_suggestion_parser.cc

+++ b/components/omnibox/browser/search_suggestion_parser.cc

@@ -376,7 +376,7 @@ scoped_ptr<base::Value> SearchSuggestionParser::DeserializeJsonData(

JSONStringValueDeserializer deserializer(json_data);

deserializer.set_allow_trailing_comma(true);

int error_code = 0;

- scoped_ptr<base::Value> data(deserializer.Deserialize(&error_code, NULL));

+ scoped_ptr<base::Value> data = deserializer.Deserialize(&error_code, NULL);

if (error_code == 0)

return data.Pass();

}