Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Unified Diff: components/json_schema/json_schema_validator_unittest_base.cc

Issue 1394993004: Make ValueDeserializer::Deserialize return scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix and add todo about not failed trybot Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/json_schema/json_schema_validator_unittest_base.cc
diff --git a/components/json_schema/json_schema_validator_unittest_base.cc b/components/json_schema/json_schema_validator_unittest_base.cc
index 38f111c66264156a4583523337eef8971e7180c3..7aae28165a8401c959746e9eef33144a0f838546 100644
--- a/components/json_schema/json_schema_validator_unittest_base.cc
+++ b/components/json_schema/json_schema_validator_unittest_base.cc
@@ -37,7 +37,8 @@ base::Value* LoadValue(const std::string& filename) {
std::string error_message;
JSONFileValueDeserializer deserializer(path);
- base::Value* result = deserializer.Deserialize(NULL, &error_message);
+ base::Value* result =
+ deserializer.Deserialize(NULL, &error_message).release();
if (!result)
ADD_FAILURE() << "Could not parse JSON: " << error_message;
return result;
« no previous file with comments | « components/bookmarks/browser/bookmark_storage.cc ('k') | components/omnibox/browser/search_suggestion_parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698