Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: chromeos/network/onc/onc_utils_unittest.cc

Issue 1394993004: Make ValueDeserializer::Deserialize return scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix and add todo about not failed trybot Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/network/onc/onc_test_utils.cc ('k') | chromeos/system/statistics_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/network/onc/onc_utils_unittest.cc
diff --git a/chromeos/network/onc/onc_utils_unittest.cc b/chromeos/network/onc/onc_utils_unittest.cc
index 6370a68507eccc4b562bf6cf28bd6f7eef4d3ec8..30053f146925911d3bae98a79b6e60d1366e941f 100644
--- a/chromeos/network/onc/onc_utils_unittest.cc
+++ b/chromeos/network/onc/onc_utils_unittest.cc
@@ -21,11 +21,11 @@ namespace chromeos {
namespace {
scoped_ptr<base::Value> ReadTestJson(const std::string& filename) {
- base::Value* result = nullptr;
base::FilePath path;
+ scoped_ptr<base::Value> result;
if (!test_utils::GetTestDataPath("network", filename, &path)) {
NOTREACHED() << "Unable to get test file path for: " << filename;
- return make_scoped_ptr(result);
+ return result;
}
JSONFileValueDeserializer deserializer(path);
deserializer.set_allow_trailing_comma(true);
@@ -33,7 +33,7 @@ scoped_ptr<base::Value> ReadTestJson(const std::string& filename) {
result = deserializer.Deserialize(nullptr, &error_message);
CHECK(result != nullptr) << "Couldn't json-deserialize file: " << filename
<< ": " << error_message;
- return make_scoped_ptr(result);
+ return result;
}
} // namespace
« no previous file with comments | « chromeos/network/onc/onc_test_utils.cc ('k') | chromeos/system/statistics_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698