Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10020)

Unified Diff: chromeos/network/onc/onc_test_utils.cc

Issue 1394993004: Make ValueDeserializer::Deserialize return scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix and add todo about not failed trybot Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/dbus/fake_easy_unlock_client.cc ('k') | chromeos/network/onc/onc_utils_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/network/onc/onc_test_utils.cc
diff --git a/chromeos/network/onc/onc_test_utils.cc b/chromeos/network/onc/onc_test_utils.cc
index 522a9ed338a8a0bf534d3574b645d37d3b39b53c..7afc0d8984f16f6aded820b39d272b585f91f8e1 100644
--- a/chromeos/network/onc/onc_test_utils.cc
+++ b/chromeos/network/onc/onc_test_utils.cc
@@ -38,29 +38,30 @@ std::string ReadTestData(const std::string& filename) {
scoped_ptr<base::DictionaryValue> ReadTestDictionary(
const std::string& filename) {
- base::DictionaryValue* dict = NULL;
+ scoped_ptr<base::DictionaryValue> dict;
base::FilePath path;
if (!chromeos::test_utils::GetTestDataPath(kNetworkComponentDirectory,
filename,
&path)) {
NOTREACHED() << "Unable to get test dictionary path for "
<< kNetworkComponentDirectory << "/" << filename;
- return make_scoped_ptr(dict);
+ return dict;
}
JSONFileValueDeserializer deserializer(path);
deserializer.set_allow_trailing_comma(true);
std::string error_message;
- base::Value* content = deserializer.Deserialize(NULL, &error_message);
+ scoped_ptr<base::Value> content =
+ deserializer.Deserialize(NULL, &error_message);
CHECK(content != NULL) << "Couldn't json-deserialize file '"
<< filename << "': " << error_message;
- CHECK(content->GetAsDictionary(&dict))
- << "File '" << filename
- << "' does not contain a dictionary as expected, but type "
- << content->GetType();
- return make_scoped_ptr(dict);
+ dict = base::DictionaryValue::From(content.Pass());
+ CHECK(dict) << "File '" << filename
+ << "' does not contain a dictionary as expected, but type "
+ << content->GetType();
+ return dict;
}
::testing::AssertionResult Equals(const base::Value* expected,
« no previous file with comments | « chromeos/dbus/fake_easy_unlock_client.cc ('k') | chromeos/network/onc/onc_utils_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698