Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4033)

Unified Diff: chrome/test/media_router/media_router_integration_browsertest.cc

Issue 1394993004: Make ValueDeserializer::Deserialize return scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix and add todo about not failed trybot Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/util/uninstall_metrics_unittest.cc ('k') | chrome/utility/importer/firefox_importer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/media_router/media_router_integration_browsertest.cc
diff --git a/chrome/test/media_router/media_router_integration_browsertest.cc b/chrome/test/media_router/media_router_integration_browsertest.cc
index 99beb38e655600f165d11225bd917780f8c997ef..3bda71218de22f9dfc528ab10e5d69504304c148 100644
--- a/chrome/test/media_router/media_router_integration_browsertest.cc
+++ b/chrome/test/media_router/media_router_integration_browsertest.cc
@@ -158,8 +158,8 @@ void MediaRouterIntegrationBrowserTest::SetTestData(
JSONFileValueDeserializer deserializer(full_path);
int error_code = 0;
std::string error_message;
- scoped_ptr<base::Value> value(
- deserializer.Deserialize(&error_code, &error_message));
+ scoped_ptr<base::Value> value =
+ deserializer.Deserialize(&error_code, &error_message);
CHECK(value.get()) << "Deserialize failed: " << error_message;
std::string test_data_str;
ASSERT_TRUE(base::JSONWriter::Write(*value, &test_data_str));
« no previous file with comments | « chrome/installer/util/uninstall_metrics_unittest.cc ('k') | chrome/utility/importer/firefox_importer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698