chrome/installer/util/uninstall_metrics_unittest.cc - Issue 1394993004: Make ValueDeserializer::Deserialize return scoped_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/uninstall_metrics_unittest.cc

Issue 1394993004: Make ValueDeserializer::Deserialize return scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix and add todo about not failed trybot Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/installer/util/uninstall_metrics.cc ('k') | chrome/test/media_router/media_router_integration_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/installer/util/uninstall_metrics_unittest.cc

diff --git a/chrome/installer/util/uninstall_metrics_unittest.cc b/chrome/installer/util/uninstall_metrics_unittest.cc

index aa0ff15c240b2f43cd52bc21d266ba7a6fd02b87..72b891f1c4d8fae4e04f1e7e5189cb627802d716 100644

--- a/chrome/installer/util/uninstall_metrics_unittest.cc

+++ b/chrome/installer/util/uninstall_metrics_unittest.cc

@@ -46,8 +46,8 @@ TEST(UninstallMetricsTest, TestExtractUninstallMetrics) {

JSONStringValueDeserializer json_deserializer(pref_string);

std::string error_message;

- scoped_ptr<base::Value> root(

- json_deserializer.Deserialize(NULL, &error_message));

+ scoped_ptr<base::Value> root =

+ json_deserializer.Deserialize(NULL, &error_message);

ASSERT_TRUE(root.get());

base::string16 uninstall_metrics_string;

« no previous file with comments | « chrome/installer/util/uninstall_metrics.cc ('k') | chrome/test/media_router/media_router_integration_browsertest.cc » ('j') | no next file with comments »