chrome/common/extensions/extension_test_util.cc - Issue 1394993004: Make ValueDeserializer::Deserialize return scoped_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension_test_util.cc

Issue 1394993004: Make ValueDeserializer::Deserialize return scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix and add todo about not failed trybot Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/extensions/extension_test_util.cc

diff --git a/chrome/common/extensions/extension_test_util.cc b/chrome/common/extensions/extension_test_util.cc

index ec223f6054631e16dc695c179ffcf6d5ad6e92b7..697be603c4bc0e2d03eb2bccbb2b1403ffc8c32f 100644

--- a/chrome/common/extensions/extension_test_util.cc

+++ b/chrome/common/extensions/extension_test_util.cc

@@ -31,7 +31,7 @@ scoped_refptr<Extension> LoadManifestUnchecked(const std::string& dir,

.AppendASCII(test_file);

JSONFileValueDeserializer deserializer(path);

- scoped_ptr<base::Value> result(deserializer.Deserialize(NULL, error));

+ scoped_ptr<base::Value> result = deserializer.Deserialize(NULL, error);

if (!result)

return NULL;

const base::DictionaryValue* dict;

« no previous file with comments | « chrome/common/component_flash_hint_file_linux.cc ('k') | chrome/installer/util/uninstall_metrics.cc » ('j') | no next file with comments »