chrome/common/component_flash_hint_file_linux.cc - Issue 1394993004: Make ValueDeserializer::Deserialize return scoped_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/component_flash_hint_file_linux.cc

Issue 1394993004: Make ValueDeserializer::Deserialize return scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix and add todo about not failed trybot Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/component_flash_hint_file_linux.cc

diff --git a/chrome/common/component_flash_hint_file_linux.cc b/chrome/common/component_flash_hint_file_linux.cc

index 160c8e83568b213873afaef7f57f1d1d2c27af69..32d856e9d7a887b7587f1af6362054f5f61bbccd 100644

--- a/chrome/common/component_flash_hint_file_linux.cc

+++ b/chrome/common/component_flash_hint_file_linux.cc

@@ -156,8 +156,8 @@ bool VerifyAndReturnFlashLocation(base::FilePath* path,

int error_code;

std::string error_message;

JSONStringValueDeserializer deserializer(json_string);

- const scoped_ptr<base::Value> value(

- deserializer.Deserialize(&error_code, &error_message));

+ const scoped_ptr<base::Value> value =

+ deserializer.Deserialize(&error_code, &error_message);

if (!value) {

LOG(ERROR)

« no previous file with comments | « chrome/browser/ui/webui/nacl_ui.cc ('k') | chrome/common/extensions/extension_test_util.cc » ('j') | no next file with comments »