chrome/browser/platform_util_unittest.cc - Issue 1394993004: Make ValueDeserializer::Deserialize return scoped_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/platform_util_unittest.cc

Issue 1394993004: Make ValueDeserializer::Deserialize return scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix and add todo about not failed trybot Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/user_script_listener_unittest.cc ('k') | chrome/browser/prefs/pref_service_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/platform_util_unittest.cc

diff --git a/chrome/browser/platform_util_unittest.cc b/chrome/browser/platform_util_unittest.cc

index cd30a7f12ed49580f002ab372548d9137a06c410..caaf200fa028a78507ff7ee82fb889d36bee2367 100644

--- a/chrome/browser/platform_util_unittest.cc

+++ b/chrome/browser/platform_util_unittest.cc

@@ -92,8 +92,8 @@ class PlatformUtilTestBase : public BrowserWithTestWindowTest {

" }"

"}";

JSONStringValueDeserializer json_string_deserializer(json_manifest);

- scoped_ptr<base::Value> manifest(

- json_string_deserializer.Deserialize(&error_code, &error));

+ scoped_ptr<base::Value> manifest =

+ json_string_deserializer.Deserialize(&error_code, &error);

base::DictionaryValue* manifest_dictionary;

manifest->GetAsDictionary(&manifest_dictionary);

« no previous file with comments | « chrome/browser/extensions/user_script_listener_unittest.cc ('k') | chrome/browser/prefs/pref_service_browsertest.cc » ('j') | no next file with comments »