Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7185)

Unified Diff: chrome/browser/extensions/user_script_listener_unittest.cc

Issue 1394993004: Make ValueDeserializer::Deserialize return scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix and add todo about not failed trybot Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/external_pref_loader.cc ('k') | chrome/browser/platform_util_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/user_script_listener_unittest.cc
diff --git a/chrome/browser/extensions/user_script_listener_unittest.cc b/chrome/browser/extensions/user_script_listener_unittest.cc
index 64099b8b2c04a2a65a73385048b04d5716055c9b..b4147f7821c3a43ff68406dbcb13117f369b247e 100644
--- a/chrome/browser/extensions/user_script_listener_unittest.cc
+++ b/chrome/browser/extensions/user_script_listener_unittest.cc
@@ -74,12 +74,13 @@ class SimpleTestJob : public net::URLRequestTestJob {
};
// Yoinked from extension_manifest_unittest.cc.
+// TODO(Olli Raula) Make this return scoped_ptr
base::DictionaryValue* LoadManifestFile(const base::FilePath path,
std::string* error) {
EXPECT_TRUE(base::PathExists(path));
JSONFileValueDeserializer deserializer(path);
- return static_cast<base::DictionaryValue*>(
- deserializer.Deserialize(NULL, error));
+ return base::DictionaryValue::From(deserializer.Deserialize(NULL, error))
+ .release();
}
scoped_refptr<Extension> LoadExtension(const std::string& filename,
« no previous file with comments | « chrome/browser/extensions/external_pref_loader.cc ('k') | chrome/browser/platform_util_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698