Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5468)

Unified Diff: base/values.h

Issue 1394993004: Make ValueDeserializer::Deserialize return scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix and add todo about not failed trybot Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/test/gtest_util.cc ('k') | chrome/browser/android/contextualsearch/contextual_search_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/values.h
diff --git a/base/values.h b/base/values.h
index 56be542d7477b8c02d725aa7690e1b82dacc70d3..a64f6a8fce03dc3cbb800bdbf8db1a9593363c71 100644
--- a/base/values.h
+++ b/base/values.h
@@ -531,7 +531,8 @@ class BASE_EXPORT ValueDeserializer {
// error_code will be set with the underlying error.
// If |error_message| is non-null, it will be filled in with a formatted
// error message including the location of the error if appropriate.
- virtual Value* Deserialize(int* error_code, std::string* error_str) = 0;
+ virtual scoped_ptr<Value> Deserialize(int* error_code,
+ std::string* error_str) = 0;
};
// Stream operator so Values can be used in assertion statements. In order that
« no previous file with comments | « base/test/gtest_util.cc ('k') | chrome/browser/android/contextualsearch/contextual_search_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698