Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: base/test/gtest_util.cc

Issue 1394993004: Make ValueDeserializer::Deserialize return scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix and add todo about not failed trybot Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/prefs/json_pref_store.cc ('k') | base/values.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/test/gtest_util.cc
diff --git a/base/test/gtest_util.cc b/base/test/gtest_util.cc
index 19cec516b1469792404898e24109c9746154089f..3f44d748df3dbfddc1e936a84174ce957f932da2 100644
--- a/base/test/gtest_util.cc
+++ b/base/test/gtest_util.cc
@@ -60,8 +60,8 @@ bool ReadTestNamesFromFile(const FilePath& path,
JSONFileValueDeserializer deserializer(path);
int error_code = 0;
std::string error_message;
- scoped_ptr<base::Value> value(
- deserializer.Deserialize(&error_code, &error_message));
+ scoped_ptr<base::Value> value =
+ deserializer.Deserialize(&error_code, &error_message);
if (!value.get())
return false;
« no previous file with comments | « base/prefs/json_pref_store.cc ('k') | base/values.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698