Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: chromeos/network/onc/onc_test_utils.cc

Issue 1394993004: Make ValueDeserializer::Deserialize return scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/onc/onc_test_utils.cc
diff --git a/chromeos/network/onc/onc_test_utils.cc b/chromeos/network/onc/onc_test_utils.cc
index 522a9ed338a8a0bf534d3574b645d37d3b39b53c..4f2b4225a0382cb84d7bd83468adb175d79aaba1 100644
--- a/chromeos/network/onc/onc_test_utils.cc
+++ b/chromeos/network/onc/onc_test_utils.cc
@@ -52,7 +52,8 @@ scoped_ptr<base::DictionaryValue> ReadTestDictionary(
deserializer.set_allow_trailing_comma(true);
std::string error_message;
- base::Value* content = deserializer.Deserialize(NULL, &error_message);
+ base::Value* content =
+ deserializer.Deserialize(NULL, &error_message).release();
CHECK(content != NULL) << "Couldn't json-deserialize file '"
<< filename << "': " << error_message;

Powered by Google App Engine
This is Rietveld 408576698