chrome/browser/extensions/api/developer_private/extension_info_generator_unittest.cc - Issue 1394993004: Make ValueDeserializer::Deserialize return scoped_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/developer_private/extension_info_generator_unittest.cc

Issue 1394993004: Make ValueDeserializer::Deserialize return scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/component_updater/component_installers_unittest.cc ('K') | « chrome/browser/component_updater/recovery_component_installer.cc ('k') | chrome/browser/extensions/api/messaging/native_messaging_host_manifest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/developer_private/extension_info_generator_unittest.cc

diff --git a/chrome/browser/extensions/api/developer_private/extension_info_generator_unittest.cc b/chrome/browser/extensions/api/developer_private/extension_info_generator_unittest.cc

index 5e43a11a139aaa322cf1b19292c42500a9c1b295..a51df9994db2e3cd02a0db4bf485630e750ccdd5 100644

--- a/chrome/browser/extensions/api/developer_private/extension_info_generator_unittest.cc

+++ b/chrome/browser/extensions/api/developer_private/extension_info_generator_unittest.cc

@@ -36,10 +36,10 @@ const char kAllHostsPermission[] = "*://*/*";

scoped_ptr<base::DictionaryValue> DeserializeJSONTestData(

const base::FilePath& path,

std::string *error) {

- base::Value* value = nullptr;

+ scoped_ptr<base::Value> value = nullptr;

Lei Zhang 2015/10/12 22:42:21 no need to initialize to nullptr.

JSONFileValueDeserializer deserializer(path);

value = deserializer.Deserialize(nullptr, error);

- return make_scoped_ptr(static_cast<base::DictionaryValue*>(value));

+ return make_scoped_ptr(static_cast<base::DictionaryValue*>(value.release()));

}

} // namespace