Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3444)

Unified Diff: chrome/browser/themes/browser_theme_pack_unittest.cc

Issue 1394993004: Make ValueDeserializer::Deserialize return scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/themes/browser_theme_pack_unittest.cc
diff --git a/chrome/browser/themes/browser_theme_pack_unittest.cc b/chrome/browser/themes/browser_theme_pack_unittest.cc
index 404dbdae4256bf52a563ab4205cdaffddc506a69..af1bfeb78ffa5a29e0c896455bc13f80d96e829f 100644
--- a/chrome/browser/themes/browser_theme_pack_unittest.cc
+++ b/chrome/browser/themes/browser_theme_pack_unittest.cc
@@ -157,7 +157,7 @@ class BrowserThemePackTest : public ::testing::Test {
JSONFileValueDeserializer deserializer(manifest_path);
scoped_ptr<base::DictionaryValue> valid_value(
static_cast<base::DictionaryValue*>(
- deserializer.Deserialize(NULL, &error)));
+ deserializer.Deserialize(NULL, &error).release()));
EXPECT_EQ("", error);
ASSERT_TRUE(valid_value.get());
scoped_refptr<Extension> extension(

Powered by Google App Engine
This is Rietveld 408576698