chrome/browser/extensions/user_script_listener_unittest.cc - Issue 1394993004: Make ValueDeserializer::Deserialize return scoped_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/user_script_listener_unittest.cc

Issue 1394993004: Make ValueDeserializer::Deserialize return scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/developer_private/extension_info_generator_unittest.cc ('K') | « chrome/browser/extensions/external_pref_loader.cc ('k') | chrome/browser/platform_util_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/user_script_listener_unittest.cc

diff --git a/chrome/browser/extensions/user_script_listener_unittest.cc b/chrome/browser/extensions/user_script_listener_unittest.cc

index 64099b8b2c04a2a65a73385048b04d5716055c9b..f2947e3f70b9f792ef4f4b9e94e7fad1d428d4b3 100644

--- a/chrome/browser/extensions/user_script_listener_unittest.cc

+++ b/chrome/browser/extensions/user_script_listener_unittest.cc

@@ -79,7 +79,7 @@ base::DictionaryValue* LoadManifestFile(const base::FilePath path,

EXPECT_TRUE(base::PathExists(path));

JSONFileValueDeserializer deserializer(path);

return static_cast<base::DictionaryValue*>(

- deserializer.Deserialize(NULL, error));

+ deserializer.Deserialize(NULL, error).release());

}

scoped_refptr<Extension> LoadExtension(const std::string& filename,