Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2078)

Unified Diff: chrome/browser/extensions/extension_icon_manager_unittest.cc

Issue 1394993004: Make ValueDeserializer::Deserialize return scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_icon_manager_unittest.cc
diff --git a/chrome/browser/extensions/extension_icon_manager_unittest.cc b/chrome/browser/extensions/extension_icon_manager_unittest.cc
index bcec7a810ac138c7fe6f4fa6be946189086570c7..505b68cc0e40dee762f3a2ac89b8e0db98a3b2a1 100644
--- a/chrome/browser/extensions/extension_icon_manager_unittest.cc
+++ b/chrome/browser/extensions/extension_icon_manager_unittest.cc
@@ -110,8 +110,8 @@ TEST_F(ExtensionIconManagerTest, LoadRemoveLoad) {
JSONFileValueDeserializer deserializer(manifest_path);
scoped_ptr<base::DictionaryValue> manifest(
- static_cast<base::DictionaryValue*>(deserializer.Deserialize(NULL,
- NULL)));
+ static_cast<base::DictionaryValue*>(
+ deserializer.Deserialize(NULL, NULL).release()));
ASSERT_TRUE(manifest.get() != NULL);
std::string error;
@@ -153,8 +153,8 @@ TEST_F(ExtensionIconManagerTest, LoadComponentExtensionResource) {
JSONFileValueDeserializer deserializer(manifest_path);
scoped_ptr<base::DictionaryValue> manifest(
- static_cast<base::DictionaryValue*>(deserializer.Deserialize(NULL,
- NULL)));
+ static_cast<base::DictionaryValue*>(
+ deserializer.Deserialize(NULL, NULL).release()));
ASSERT_TRUE(manifest.get() != NULL);
std::string error;

Powered by Google App Engine
This is Rietveld 408576698