bluetooth: android: Create BluetoothRemoteGattServiceAndroid objects.

bluetooth: android: Create BluetoothRemoteGattServiceAndroid objects.

Initiate GATT service discovery when a connection is established. Upon
discovery completion create C++ objects associated with the Java objects.
For now these are simple stubs, and don't even retain the Java object.

BUG=541355
Committed: https://crrev.com/c3ecc9fc96c00be7da6c16f7e67b5689c5565437
Cr-Commit-Position: refs/heads/master@{#353465}

[scheib, 2015-10-08 22:00:42]

scheib@chromium.org changed reviewers:
+ ortuno@chromium.org

[ortuno, 2015-10-08 22:53:28]

lgtm

https://codereview.chromium.org/1394973003/diff/1/device/bluetooth/bluetooth_...
File device/bluetooth/bluetooth_adapter_android.h (right):

https://codereview.chromium.org/1394973003/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_adapter_android.h:87:
base::ObserverList<device::BluetoothAdapter::Observer>& GetObservers() {
Why is this not bluetooth_adapter.h/cc?

https://codereview.chromium.org/1394973003/diff/1/device/bluetooth/bluetooth_...
File device/bluetooth/bluetooth_device_unittest.cc (right):

https://codereview.chromium.org/1394973003/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_device_unittest.cc:435: ResetEventCounts();
Any reason why you have this here instead of in a SetUp or TearDown function?

https://code.google.com/p/chromium/codesearch#chromium/src/testing/gtest/incl...

https://codereview.chromium.org/1394973003/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_device_unittest.cc:440: // their properties.
Link to issue?

https://codereview.chromium.org/1394973003/diff/1/device/bluetooth/test/andro...
File
device/bluetooth/test/android/java/src/org/chromium/device/bluetooth/Fakes.java
(right):

https://codereview.chromium.org/1394973003/diff/1/device/bluetooth/test/andro...
device/bluetooth/test/android/java/src/org/chromium/device/bluetooth/Fakes.java:219:
// their properties.
Same here: issue? Or are you planning on doing this in a follow up patch?

[scheib, 2015-10-08 23:52:20]

https://codereview.chromium.org/1394973003/diff/1/device/bluetooth/bluetooth_...
File device/bluetooth/bluetooth_adapter_android.h (right):

https://codereview.chromium.org/1394973003/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_adapter_android.h:87:
base::ObserverList<device::BluetoothAdapter::Observer>& GetObservers() {
On 2015/10/08 22:53:27, ortuno wrote:
> Why is this not bluetooth_adapter.h/cc?

Explained in comment.

https://codereview.chromium.org/1394973003/diff/1/device/bluetooth/bluetooth_...
File device/bluetooth/bluetooth_device_unittest.cc (right):

https://codereview.chromium.org/1394973003/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_device_unittest.cc:435: ResetEventCounts();
On 2015/10/08 22:53:27, ortuno wrote:
> Any reason why you have this here instead of in a SetUp or TearDown function?
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/testing/gtest/incl...

Placing it immediately before and the EXPECT after the method under test ensures
that the event is generated as a side effect of that method.

https://codereview.chromium.org/1394973003/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_device_unittest.cc:440: // their properties.
On 2015/10/08 22:53:27, ortuno wrote:
> Link to issue?

Done.

https://codereview.chromium.org/1394973003/diff/1/device/bluetooth/test/andro...
File
device/bluetooth/test/android/java/src/org/chromium/device/bluetooth/Fakes.java
(right):

https://codereview.chromium.org/1394973003/diff/1/device/bluetooth/test/andro...
device/bluetooth/test/android/java/src/org/chromium/device/bluetooth/Fakes.java:219:
// their properties.
On 2015/10/08 22:53:27, ortuno wrote:
> Same here: issue? Or are you planning on doing this in a follow up patch?

Done.

[scheib, 2015-10-10 14:42:00]

The CQ bit was checked by scheib@chromium.org

[scheib, 2015-10-10 14:42:00]

The patchset sent to the CQ was uploaded after l-g-t-m from ortuno@chromium.org
Link to the patchset: https://codereview.chromium.org/1394973003/#ps20001
(title: "Address ortuno")

[commit-bot: I haz the power, 2015-10-10 14:42:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1394973003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1394973003/20001

[commit-bot: I haz the power, 2015-10-10 15:49:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-10 15:50:22]

Patchset 2 (id:??) landed as
https://crrev.com/c3ecc9fc96c00be7da6c16f7e67b5689c5565437
Cr-Commit-Position: refs/heads/master@{#353465}