Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1380883003: bluetooth: Refactor BluetoothTest member names. (Closed)

Created:
5 years, 2 months ago by scheib
Modified:
5 years, 2 months ago
Reviewers:
ortuno
CC:
asanka, benjhayden+dwatch_chromium.org, chromium-reviews, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@bt-hold-connections-
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Refactor BluetoothTest member names. Rename *_attempt_count_ -> *_attempts_. Add 'Fake' into OnFakeBluetoothDeviceConnectGattCalled. Use 'Simulate' prefix on test fixture methods the simulate a platform action. Committed: https://crrev.com/93a67f3b1e93a74dd7f2095aed1c39f3d64e9f22 Cr-Commit-Position: refs/heads/master@{#353178}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -59 lines) Patch
M device/bluetooth/bluetooth_device_unittest.cc View 14 chunks +34 lines, -34 lines 0 comments Download
M device/bluetooth/test/android/java/src/org/chromium/device/bluetooth/Fakes.java View 2 chunks +3 lines, -3 lines 0 comments Download
M device/bluetooth/test/bluetooth_test.h View 2 chunks +6 lines, -6 lines 0 comments Download
M device/bluetooth/test/bluetooth_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M device/bluetooth/test/bluetooth_test_android.h View 1 chunk +5 lines, -5 lines 0 comments Download
M device/bluetooth/test/bluetooth_test_android.cc View 4 chunks +8 lines, -9 lines 0 comments Download

Dependent Patchsets:

Issue 1394973003 Patch 1
Issue 1394973003 Patch 20001

Messages

Total messages: 8 (3 generated)
scheib
5 years, 2 months ago (2015-10-08 21:50:01 UTC) #2
ortuno
lgtm
5 years, 2 months ago (2015-10-08 21:52:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1380883003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1380883003/20001
5 years, 2 months ago (2015-10-08 23:36:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 2 months ago (2015-10-09 00:06:08 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-09 00:06:51 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/93a67f3b1e93a74dd7f2095aed1c39f3d64e9f22
Cr-Commit-Position: refs/heads/master@{#353178}

Powered by Google App Engine
This is Rietveld 408576698