Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1394923003: Use WorldImpact for element dependencies in deferred_load (Closed)

Created:
5 years, 2 months ago by Johnni Winther
Modified:
5 years, 2 months ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org, Harry Terkelsen
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use WorldImpact for element dependencies in deferred_load BUG= R=sigurdm@google.com Committed: https://github.com/dart-lang/sdk/commit/26d6a8363e3d8b19cd630d9469f0b9f43b2f46c5

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -78 lines) Patch
M pkg/compiler/lib/src/common/codegen.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/common/resolution.dart View 6 chunks +21 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/compile_time_constants.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 6 chunks +23 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/dart_backend/dart_backend.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/deferred_load.dart View 3 chunks +72 lines, -27 lines 4 comments Download
M pkg/compiler/lib/src/enqueue.dart View 1 chunk +27 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/helpers/debug_collection.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/js_backend.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/constructors.dart View 3 chunks +13 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/resolution/registry.dart View 12 chunks +13 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 6 chunks +7 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/use_unused_api.dart View 5 chunks +12 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
5 years, 2 months ago (2015-10-13 13:58:42 UTC) #2
sigurdm
LGTM https://codereview.chromium.org/1394923003/diff/1/pkg/compiler/lib/src/deferred_load.dart File pkg/compiler/lib/src/deferred_load.dart (right): https://codereview.chromium.org/1394923003/diff/1/pkg/compiler/lib/src/deferred_load.dart#newcode302 pkg/compiler/lib/src/deferred_load.dart:302: // way to query "liveness". Move this TODO ...
5 years, 2 months ago (2015-10-14 08:00:36 UTC) #3
Johnni Winther
https://codereview.chromium.org/1394923003/diff/1/pkg/compiler/lib/src/deferred_load.dart File pkg/compiler/lib/src/deferred_load.dart (right): https://codereview.chromium.org/1394923003/diff/1/pkg/compiler/lib/src/deferred_load.dart#newcode302 pkg/compiler/lib/src/deferred_load.dart:302: // way to query "liveness". On 2015/10/14 08:00:36, sigurdm ...
5 years, 2 months ago (2015-10-14 08:42:16 UTC) #4
Johnni Winther
5 years, 2 months ago (2015-10-14 09:12:26 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
26d6a8363e3d8b19cd630d9469f0b9f43b2f46c5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698