Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Unified Diff: pkg/compiler/lib/src/resolution/resolution.dart

Issue 1394923003: Use WorldImpact for element dependencies in deferred_load (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/resolution/resolution.dart
diff --git a/pkg/compiler/lib/src/resolution/resolution.dart b/pkg/compiler/lib/src/resolution/resolution.dart
index ef5c04f199decfe7d8488c1df9faff384e71f0ac..1d20e772fa895d763f05a77da9776571a3967109 100644
--- a/pkg/compiler/lib/src/resolution/resolution.dart
+++ b/pkg/compiler/lib/src/resolution/resolution.dart
@@ -12,7 +12,7 @@ import '../common/names.dart' show
import '../common/resolution.dart' show
Parsing,
Resolution,
- ResolutionWorldImpact;
+ ResolutionImpact;
import '../common/tasks.dart' show
CompilerTask,
DeferredAction;
@@ -70,14 +70,14 @@ class ResolverTask extends CompilerTask {
Parsing get parsing => compiler.parsing;
- ResolutionWorldImpact resolve(Element element) {
+ ResolutionImpact resolve(Element element) {
return measure(() {
if (Elements.isErroneous(element)) {
// TODO(johnniwinther): Add a predicate for this.
assert(invariant(element, element is! ErroneousElement,
message: "Element $element expected to have parse errors."));
_ensureTreeElements(element);
- return const ResolutionWorldImpact();
+ return const ResolutionImpact();
}
WorldImpact processMetadata([WorldImpact result]) {
@@ -101,7 +101,7 @@ class ResolverTask extends CompilerTask {
if (element.isClass) {
ClassElement cls = element;
cls.ensureResolved(resolution);
- return processMetadata(const ResolutionWorldImpact());
+ return processMetadata(const ResolutionImpact());
} else if (element.isTypedef) {
TypedefElement typdef = element;
return processMetadata(resolveTypedef(typdef));
@@ -285,7 +285,7 @@ class ResolverTask extends CompilerTask {
assert(invariant(element, element.isConstructor,
message: 'Non-constructor element $element '
'has already been analyzed.'));
- return const ResolutionWorldImpact();
+ return const ResolutionImpact();
}
if (element.isSynthesized) {
if (element.isGenerativeConstructor) {
@@ -305,7 +305,7 @@ class ResolverTask extends CompilerTask {
} else {
assert(element.isDeferredLoaderGetter || element.isErroneous);
_ensureTreeElements(element);
- return const ResolutionWorldImpact();
+ return const ResolutionImpact();
}
} else {
element.parseNode(resolution.parsing);
@@ -987,7 +987,7 @@ class ResolverTask extends CompilerTask {
}
WorldImpact resolveTypedef(TypedefElementX element) {
- if (element.isResolved) return const ResolutionWorldImpact();
+ if (element.isResolved) return const ResolutionImpact();
compiler.world.allTypedefs.add(element);
return _resolveTypeDeclaration(element, () {
ResolutionRegistry registry = new ResolutionRegistry(

Powered by Google App Engine
This is Rietveld 408576698