Implement download link in chrome://indexeddb-internals/

content/browser/indexed_db/indexed_db_context_impl.h

Index: content/browser/indexed_db/indexed_db_context_impl.h
diff --git a/content/browser/indexed_db/indexed_db_context_impl.h b/content/browser/indexed_db/indexed_db_context_impl.h
index 52aa57b052c1ff9fea447a8f742faa132d78058c..db4da12903590ff742c07daf6e1d3a07d171afb5 100644
--- a/content/browser/indexed_db/indexed_db_context_impl.h
+++ b/content/browser/indexed_db/indexed_db_context_impl.h
@@ -54,9 +54,7 @@ class CONTENT_EXPORT IndexedDBContextImpl
   static const base::FilePath::CharType kIndexedDBExtension[];
 
   // Disables the exit-time deletion of session-only data.
-  void SetForceKeepSessionState() {
-    force_keep_session_state_ = true;
-  }
+  void SetForceKeepSessionState() { force_keep_session_state_ = true; }

[jsbell, 2013/04/29 19:16:14]

Looks like you ran clang-format over this?

[alecflett, 2013/04/29 22:28:16]

yes.

 
   // IndexedDBContext implementation:
   virtual std::vector<GURL> GetAllOrigins() OVERRIDE;
@@ -64,8 +62,8 @@ class CONTENT_EXPORT IndexedDBContextImpl
   virtual int64 GetOriginDiskUsage(const GURL& origin_url) OVERRIDE;
   virtual base::Time GetOriginLastModified(const GURL& origin_url) OVERRIDE;
   virtual void DeleteForOrigin(const GURL& origin_url) OVERRIDE;
-  virtual base::FilePath GetFilePathForTesting(
-      const string16& origin_id) const OVERRIDE;
+  virtual base::FilePath GetFilePathForTesting(const string16& origin_id) const
+      OVERRIDE;
 
   // Methods called by IndexedDBDispatcherHost for quota support.
   void ConnectionOpened(const GURL& origin_url, WebKit::WebIDBDatabase*);
@@ -76,6 +74,9 @@ class CONTENT_EXPORT IndexedDBContextImpl
 
   quota::QuotaManagerProxy* quota_manager_proxy();
 
+  void ForceClose(const GURL& origin_url);
+  base::FilePath GetFilePath(const GURL& origin_url);
+  bool HasOrigin(const GURL& origin_url);
   base::FilePath data_path() const { return data_path_; }
 
   // For unit tests allow to override the |data_path_|.
@@ -100,8 +101,10 @@ class CONTENT_EXPORT IndexedDBContextImpl
   int64 ReadUsageFromDisk(const GURL& origin_url) const;
   void EnsureDiskUsageCacheInitialized(const GURL& origin_url);
   void QueryDiskAndUpdateQuotaUsage(const GURL& origin_url);
-  void GotUsageAndQuota(const GURL& origin_url, quota::QuotaStatusCode,
-                        int64 usage, int64 quota);
+  void GotUsageAndQuota(const GURL& origin_url,
+                        quota::QuotaStatusCode,
+                        int64 usage,
+                        int64 quota);
   void GotUpdatedQuota(const GURL& origin_url, int64 usage, int64 quota);
   void QueryAvailableQuota(const GURL& origin_url);
 
@@ -112,10 +115,6 @@ class CONTENT_EXPORT IndexedDBContextImpl
   void RemoveFromOriginSet(const GURL& origin_url) {
     GetOriginSet()->erase(origin_url);
   }
-  bool IsInOriginSet(const GURL& origin_url) {

[jsbell, 2013/04/29 19:16:14]

Just a minor note about the name change here (IsInOriginSet -> HasOrigin). 

The previous naming of these 3 methods
(AddToOriginSet/RemoveOriginSet/IsInOriginSet) implied that a
IndexedDBContextImpl "has a" collection of origins. And, of course, there's
GetOriginSet which returns the actual set.

The name HasOrigin implies that IndexedDBContextImpl "is a" collection of
origins, but the other methods still have the old implication, and the set is
still directly accessible via GetOriginSet.

I'm not sure what I'm suggesting here, but the rename feels a bit arbitrary.

[alecflett, 2013/04/29 22:28:16]

oops this is somewhat leftover from an earlier version of the patch where I
thought I was going to be exposing this as a virtual from IndexedDBContext* -
I'll put it back, but I will need to make it public

FWIW I find the verb-preposition form awkward ("AddToOriginSet" instead of
"AddOrigin") but I won't fix that here

-    std::set<GURL>* set = GetOriginSet();
-    return set->find(origin_url) != set->end();
-  }
 
   // Only for testing.
   void ResetCaches();