Implement download link in chrome://indexeddb-internals/

content/browser/indexed_db/indexed_db_context_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_INDEXED_DB_INDEXED_DB_CONTEXT_IMPL_H_
 #define CONTENT_BROWSER_INDEXED_DB_INDEXED_DB_CONTEXT_IMPL_H_
 
 #include <map>
 #include <set>
 #include <vector>
@@ skipping 36 matching lines @@
 
   WebKit::WebIDBFactory* GetIDBFactory();
 
   // The indexed db directory.
   static const base::FilePath::CharType kIndexedDBDirectory[];
 
   // The indexed db file extension.
   static const base::FilePath::CharType kIndexedDBExtension[];
 
   // Disables the exit-time deletion of session-only data.
-  void SetForceKeepSessionState() {
-    force_keep_session_state_ = true;
-  }
+  void SetForceKeepSessionState() { force_keep_session_state_ = true; }

[jsbell, 2013/04/29 19:16:14]

Looks like you ran clang-format over this?

[alecflett, 2013/04/29 22:28:16]

yes.

 
   // IndexedDBContext implementation:
   virtual std::vector<GURL> GetAllOrigins() OVERRIDE;
   virtual std::vector<IndexedDBInfo> GetAllOriginsInfo() OVERRIDE;
   virtual int64 GetOriginDiskUsage(const GURL& origin_url) OVERRIDE;
   virtual base::Time GetOriginLastModified(const GURL& origin_url) OVERRIDE;
   virtual void DeleteForOrigin(const GURL& origin_url) OVERRIDE;
-  virtual base::FilePath GetFilePathForTesting(
-      const string16& origin_id) const OVERRIDE;
+  virtual base::FilePath GetFilePathForTesting(const string16& origin_id) const
+      OVERRIDE;
 
   // Methods called by IndexedDBDispatcherHost for quota support.
   void ConnectionOpened(const GURL& origin_url, WebKit::WebIDBDatabase*);
   void ConnectionClosed(const GURL& origin_url, WebKit::WebIDBDatabase*);
   void TransactionComplete(const GURL& origin_url);
   bool WouldBeOverQuota(const GURL& origin_url, int64 additional_bytes);
   bool IsOverQuota(const GURL& origin_url);
 
   quota::QuotaManagerProxy* quota_manager_proxy();
 
+  void ForceClose(const GURL& origin_url);
+  base::FilePath GetFilePath(const GURL& origin_url);
+  bool HasOrigin(const GURL& origin_url);
   base::FilePath data_path() const { return data_path_; }
 
   // For unit tests allow to override the |data_path_|.
   void set_data_path_for_testing(const base::FilePath& data_path) {
     data_path_ = data_path;
   }
 
  protected:
   virtual ~IndexedDBContextImpl();
 
  private:
   FRIEND_TEST_ALL_PREFIXES(IndexedDBTest, ClearLocalState);
   FRIEND_TEST_ALL_PREFIXES(IndexedDBTest, ClearSessionOnlyDatabases);
   FRIEND_TEST_ALL_PREFIXES(IndexedDBTest, SetForceKeepSessionState);
   FRIEND_TEST_ALL_PREFIXES(IndexedDBTest, ForceCloseOpenDatabasesOnDelete);
   friend class IndexedDBQuotaClientTest;
 
   typedef std::map<GURL, int64> OriginToSizeMap;
   class IndexedDBGetUsageAndQuotaCallback;
 
   base::FilePath GetIndexedDBFilePath(const string16& origin_id) const;
   int64 ReadUsageFromDisk(const GURL& origin_url) const;
   void EnsureDiskUsageCacheInitialized(const GURL& origin_url);
   void QueryDiskAndUpdateQuotaUsage(const GURL& origin_url);
-  void GotUsageAndQuota(const GURL& origin_url, quota::QuotaStatusCode,
-                        int64 usage, int64 quota);
+  void GotUsageAndQuota(const GURL& origin_url,
+                        quota::QuotaStatusCode,
+                        int64 usage,
+                        int64 quota);
   void GotUpdatedQuota(const GURL& origin_url, int64 usage, int64 quota);
   void QueryAvailableQuota(const GURL& origin_url);
 
   std::set<GURL>* GetOriginSet();
   bool AddToOriginSet(const GURL& origin_url) {
     return GetOriginSet()->insert(origin_url).second;
   }
   void RemoveFromOriginSet(const GURL& origin_url) {
     GetOriginSet()->erase(origin_url);
   }
-  bool IsInOriginSet(const GURL& origin_url) {

[jsbell, 2013/04/29 19:16:14]

Just a minor note about the name change here (IsInOriginSet -> HasOrigin). 

The previous naming of these 3 methods
(AddToOriginSet/RemoveOriginSet/IsInOriginSet) implied that a
IndexedDBContextImpl "has a" collection of origins. And, of course, there's
GetOriginSet which returns the actual set.

The name HasOrigin implies that IndexedDBContextImpl "is a" collection of
origins, but the other methods still have the old implication, and the set is
still directly accessible via GetOriginSet.

I'm not sure what I'm suggesting here, but the rename feels a bit arbitrary.

[alecflett, 2013/04/29 22:28:16]

oops this is somewhat leftover from an earlier version of the patch where I
thought I was going to be exposing this as a virtual from IndexedDBContext* -
I'll put it back, but I will need to make it public

FWIW I find the verb-preposition form awkward ("AddToOriginSet" instead of
"AddOrigin") but I won't fix that here

-    std::set<GURL>* set = GetOriginSet();
-    return set->find(origin_url) != set->end();
-  }
 
   // Only for testing.
   void ResetCaches();
 
   scoped_ptr<WebKit::WebIDBFactory> idb_factory_;
   base::FilePath data_path_;
   // If true, nothing (not even session-only data) should be deleted on exit.
   bool force_keep_session_state_;
   scoped_refptr<quota::SpecialStoragePolicy> special_storage_policy_;
   scoped_refptr<quota::QuotaManagerProxy> quota_manager_proxy_;
   scoped_ptr<std::set<GURL> > origin_set_;
   OriginToSizeMap origin_size_map_;
   OriginToSizeMap space_available_map_;
   typedef std::set<WebKit::WebIDBDatabase*> ConnectionSet;
   std::map<GURL, ConnectionSet> connections_;
 
   DISALLOW_COPY_AND_ASSIGN(IndexedDBContextImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_INDEXED_DB_INDEXED_DB_CONTEXT_IMPL_H_