Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13949011: Cleanup: Remove unnecessary ".get()" from scoped_ptrs<>. (Closed)

Created:
7 years, 8 months ago by Elliot Glaysher
Modified:
7 years, 8 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Cleanup: Remove unnecessary ".get()" from scoped_ptrs<>. In r174057, enne@ added support for implicit testing to scoped_ptr<>. Removes these in chrome/browser/extensions/. BUG=232084 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194616

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -58 lines) Patch
M chrome/browser/extensions/activity_log.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/activity_log.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/component_loader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/event_listener_map.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_action.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_action_icon_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_action_icon_factory_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_creator.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_function.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_icon_image_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_info_map.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_info_map_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_system.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/external_pref_loader.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/image_loader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/installed_loader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/media_galleries_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/menu_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/menu_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/permissions_updater_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/requirements_checker.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/sandboxed_unpacker.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/startup_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/tab_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/test_extension_prefs.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/unpacked_installer.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/user_script_listener_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/webstore_data_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/webstore_install_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/webstore_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/webstore_standalone_installer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Elliot Glaysher
7 years, 8 months ago (2013-04-16 21:35:07 UTC) #1
Yoyo Zhou
LGTM
7 years, 8 months ago (2013-04-16 23:07:33 UTC) #2
Elliot Glaysher
7 years, 8 months ago (2013-04-17 17:00:18 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r194616 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698