Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7024)

Unified Diff: chrome/browser/extensions/extension_creator.cc

Issue 13949011: Cleanup: Remove unnecessary ".get()" from scoped_ptrs<>. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_creator.cc
diff --git a/chrome/browser/extensions/extension_creator.cc b/chrome/browser/extensions/extension_creator.cc
index 9ac76e8db2a01ac27db3bb0b8328a960e0454ab5..b7724c0b68dc5df363976291659829420568597d 100644
--- a/chrome/browser/extensions/extension_creator.cc
+++ b/chrome/browser/extensions/extension_creator.cc
@@ -150,7 +150,7 @@ crypto::RSAPrivateKey* ExtensionCreator::GenerateKey(const base::FilePath&
output_private_key_path) {
scoped_ptr<crypto::RSAPrivateKey> key_pair(
crypto::RSAPrivateKey::Create(kRSAKeySize));
- if (!key_pair.get()) {
+ if (!key_pair) {
error_message_ =
l10n_util::GetStringUTF8(IDS_EXTENSION_PRIVATE_KEY_FAILED_TO_GENERATE);
return NULL;
@@ -250,7 +250,7 @@ bool ExtensionCreator::WriteCRX(const base::FilePath& zip_path,
CrxFile::Error error;
scoped_ptr<CrxFile> crx(
CrxFile::Create(public_key.size(), signature.size(), &error));
- if (!crx.get()) {
+ if (!crx) {
LOG(ERROR) << "cannot create CrxFileHeader: " << error;
}
const CrxFile::Header header = crx->header();
@@ -299,7 +299,7 @@ bool ExtensionCreator::Run(const base::FilePath& extension_dir,
key_pair.reset(ReadInputKey(private_key_path));
else
key_pair.reset(GenerateKey(output_private_key_path));
- if (!key_pair.get())
+ if (!key_pair)
return false;
// Perform some extra validation by loading the extension.
« no previous file with comments | « chrome/browser/extensions/extension_action_icon_factory_unittest.cc ('k') | chrome/browser/extensions/extension_function.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698