Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1223)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1394563003: Add long line exception for GEN('#include') in JS browser tests. (Closed)

Created:
5 years, 2 months ago by Dan Beam
Modified:
4 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add long line exception for GEN('#include') in JS browser tests. It's basically like C++'s #include but in JS. Why write 1 language when you can write 2?! R=maruel@chromium.org BUG=540977 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297065

Patch Set 1 #

Total comments: 2

Patch Set 2 : maruel@ blocking my stupid #

Total comments: 4

Patch Set 3 : #thankspython #

Total comments: 2

Patch Set 4 : gar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M presubmit_canned_checks.py View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download
M tests/presubmit_unittest.py View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
Dan Beam
5 years, 2 months ago (2015-10-08 03:05:27 UTC) #1
M-A Ruel
https://codereview.chromium.org/1394563003/diff/1/presubmit_canned_checks.py File presubmit_canned_checks.py (right): https://codereview.chromium.org/1394563003/diff/1/presubmit_canned_checks.py#newcode343 presubmit_canned_checks.py:343: JAVA_FILE_EXTS = ('java') keep the comma, it's needed. #thankspython
5 years, 2 months ago (2015-10-08 12:39:18 UTC) #2
Dan Beam
https://codereview.chromium.org/1394563003/diff/1/presubmit_canned_checks.py File presubmit_canned_checks.py (right): https://codereview.chromium.org/1394563003/diff/1/presubmit_canned_checks.py#newcode343 presubmit_canned_checks.py:343: JAVA_FILE_EXTS = ('java') On 2015/10/08 12:39:18, M-A Ruel wrote: ...
5 years, 2 months ago (2015-10-08 17:28:21 UTC) #3
M-A Ruel
https://codereview.chromium.org/1394563003/diff/20001/presubmit_canned_checks.py File presubmit_canned_checks.py (right): https://codereview.chromium.org/1394563003/diff/20001/presubmit_canned_checks.py#newcode345 presubmit_canned_checks.py:345: JS_FILE_EXTS = ('js') add comma there too https://codereview.chromium.org/1394563003/diff/20001/presubmit_canned_checks.py#newcode350 presubmit_canned_checks.py:350: ...
5 years, 2 months ago (2015-10-08 17:33:41 UTC) #4
Dan Beam
https://codereview.chromium.org/1394563003/diff/20001/presubmit_canned_checks.py File presubmit_canned_checks.py (right): https://codereview.chromium.org/1394563003/diff/20001/presubmit_canned_checks.py#newcode345 presubmit_canned_checks.py:345: JS_FILE_EXTS = ('js') On 2015/10/08 17:33:41, M-A Ruel wrote: ...
5 years, 2 months ago (2015-10-08 17:38:45 UTC) #5
M-A Ruel
https://codereview.chromium.org/1394563003/diff/40001/presubmit_canned_checks.py File presubmit_canned_checks.py (right): https://codereview.chromium.org/1394563003/diff/40001/presubmit_canned_checks.py#newcode346 presubmit_canned_checks.py:346: JS_EXCEPTIONS = ("GEN('#include") need one there too
5 years, 2 months ago (2015-10-08 17:39:30 UTC) #6
Dan Beam
https://codereview.chromium.org/1394563003/diff/40001/presubmit_canned_checks.py File presubmit_canned_checks.py (right): https://codereview.chromium.org/1394563003/diff/40001/presubmit_canned_checks.py#newcode346 presubmit_canned_checks.py:346: JS_EXCEPTIONS = ("GEN('#include") On 2015/10/08 17:39:29, M-A Ruel wrote: ...
5 years, 2 months ago (2015-10-08 17:48:06 UTC) #7
M-A Ruel
lgtm
5 years, 2 months ago (2015-10-08 17:49:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1394563003/2 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1394563003/2
5 years, 2 months ago (2015-10-08 17:50:32 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-08 17:52:31 UTC) #11
Message was sent while issue was closed. 
Committed patchset #4 (id:2) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=297065

Powered by Google App Engine
This is Rietveld 408576698