Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(944)

Unified Diff: tests/presubmit_unittest.py

Issue 1394563003: Add long line exception for GEN('#include') in JS browser tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: gar Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « presubmit_canned_checks.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/presubmit_unittest.py
diff --git a/tests/presubmit_unittest.py b/tests/presubmit_unittest.py
index 87832d46c3eeb5c27b3de5f59742649535587531..d72b6b1e885c4f72298929c4970ac4f00a9d9630 100755
--- a/tests/presubmit_unittest.py
+++ b/tests/presubmit_unittest.py
@@ -2179,6 +2179,12 @@ class CannedChecksUnittest(PresubmitTestsBase):
'importSomething ' + 'A ' * 50, 'foo.java',
presubmit.OutputApi.PresubmitPromptWarning)
+ def testCannedCheckJSLongLines(self):
+ check = lambda x, y, _: presubmit_canned_checks.CheckLongLines(x, y, 10)
+ self.ContentTest(check, 'GEN(\'#include "c/b/ui/webui/fixture.h"\');',
+ 'foo.js', "// GEN('something');", 'foo.js',
+ presubmit.OutputApi.PresubmitPromptWarning)
+
def testCannedCheckObjCExceptionLongLines(self):
check = lambda x, y, _: presubmit_canned_checks.CheckLongLines(x, y, 80)
self.ContentTest(check, '#import ' + 'A ' * 150, 'foo.mm',
« no previous file with comments | « presubmit_canned_checks.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698