External Stylesheets preloaded according to their media attribute

External Stylesheets preloaded according to their media attribute

BUG= https://bugs.webkit.org/show_bug.cgi?id=106198

The PreloadScanner currently loads external style sheets with a non-matching media query, as long as the media type is "screen".
This can result in unnecessary delay to the page's first paint, since these resource are "very low priority". 

Change description: 
The PreloadScanner passes the media attribute string to the ResourcePreloader, and the ResourcePreloader evaluates the MQs using the document's existing RenderStyle and Frame. 
The MQ resolution bits were moved to HTMLResourcePreloader.cpp, so this dependency is removed from HTMLPreloadScanner.cpp and added to HTMLResourcePreloader.cpp. 
RenderObject dependency added to HTMLResourcePreloader.cpp.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148161

[Yoav Weiss, 2013-04-10 20:06:56]

Hi,

I've re-uploaded the change using "git cl" and added description. I'll delete
the previous issue.

Yoav

[eseidel, 2013-04-10 20:09:12]

lgtm

[commit-bot: I haz the power, 2013-04-10 20:09:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoav@yoav.ws/13945017/1

[eseidel, 2013-04-10 20:10:34]

I think I have to make sure you've gone through:
http://dev.chromium.org/developers/contributing-code/external-contributor-che...

Have you?  We don't have an AUTHORS list for Chromium, but you do have to click
through the CLA.

[commit-bot: I haz the power, 2013-04-10 20:15:38]

Presubmit check for 13945017-1 failed and returned exit status -2001.
The presubmit check was hung. It took 360.0 seconds to execute and the time
limit is 360.0 seconds.

INFO:root:Found 7 file(s).

[Yoav Weiss, 2013-04-10 20:23:23]

On 2013/04/10 20:15:38, I haz the power (commit-bot) wrote:
> Presubmit check for 13945017-1 failed and returned exit status -2001.
> The presubmit check was hung. It took 360.0 seconds to execute and the time
> limit is 360.0 seconds.
> 
> INFO:root:Found 7 file(s).

I've signed the CLA. I'm not sure what the presubmit check failure means... Is
there a problem with the patch?

[eseidel, 2013-04-10 20:31:34]

I suspect our tools may just be dumb and the fact that I removed the CQ after
clicking it probably caused it to fail? Not sure.

[commit-bot: I haz the power, 2013-04-10 20:32:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoav@yoav.ws/13945017/1

[commit-bot: I haz the power, 2013-04-10 20:38:28]

Presubmit check for 13945017-1 failed and returned exit status -2001.
The presubmit check was hung. It took 360.0 seconds to execute and the time
limit is 360.0 seconds.

INFO:root:Found 7 file(s).

[eseidel, 2013-04-10 20:42:55]

I'm sorry, I don't know how to interpret that message.  Maybe Dirk or maruel do.

[eseidel, 2013-04-10 20:43:03]

I'm sorry, I don't know how to interpret that message.  Maybe Dirk or maruel do.

[Yoav Weiss, 2013-04-10 20:50:31]

On 2013/04/10 20:43:03, Eric Seidel (Google) wrote:
> I'm sorry, I don't know how to interpret that message.  Maybe Dirk or maruel
do.

In https://chromium-status.appspot.com/cq/yoav@yoav.ws/13945017/1 I see the
message "CQ bit was unchecked on CL. Ignoring." 
I see a "commit" checkbox below the patchset. Should it be checked?

[eseidel, 2013-04-10 20:56:06]

I think the CQ is just wedged atm.  I'm seeing this -2001 failure on other
reviews.  I recommend we just trying checking the CQ box again in an hour or
two?

[Yoav Weiss, 2013-04-10 21:00:10]

On 2013/04/10 20:56:06, Eric Seidel (Google) wrote:
> I think the CQ is just wedged atm.  I'm seeing this -2001 failure on other
> reviews.  I recommend we just trying checking the CQ box again in an hour or
> two?

Sure.

[commit-bot: I haz the power, 2013-04-10 21:52:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoav@yoav.ws/13945017/1

[commit-bot: I haz the power, 2013-04-10 21:58:34]

Presubmit check for 13945017-1 failed and returned exit status -2001.
The presubmit check was hung. It took 360.0 seconds to execute and the time
limit is 360.0 seconds.

INFO:root:Found 7 file(s).

[commit-bot: I haz the power, 2013-04-10 22:35:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoav@yoav.ws/13945017/1

[commit-bot: I haz the power, 2013-04-10 22:41:08]

Presubmit check for 13945017-1 failed and returned exit status -2001.
The presubmit check was hung. It took 360.0 seconds to execute and the time
limit is 360.0 seconds.

INFO:root:Found 7 file(s).

[abarth-chromium, 2013-04-10 22:42:04]

The commit-queue seems broken.  We should land this by hand.  Eric, would you
like to do that, or should I?

[commit-bot: I haz the power, 2013-04-11 05:13:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoav@yoav.ws/13945017/1

[commit-bot: I haz the power, 2013-04-11 05:19:55]

Presubmit check for 13945017-1 failed and returned exit status -2001.
The presubmit check was hung. It took 360.0 seconds to execute and the time
limit is 360.0 seconds.

INFO:root:Found 7 file(s).

[abarth-chromium, 2013-04-11 07:56:27]

Committed patchset #1 manually as r148161 (presubmit successful).