Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: sdk/lib/svg/dart2js/svg_dart2js.dart

Issue 13945009: Make default argument to Iterable.join be "". (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/io/io_sink.dart ('k') | sdk/lib/svg/dartium/svg_dartium.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/svg/dart2js/svg_dart2js.dart
diff --git a/sdk/lib/svg/dart2js/svg_dart2js.dart b/sdk/lib/svg/dart2js/svg_dart2js.dart
index 718aab052cf1ca896a261c427b6e7df7c9e63369..91f2e07f00f75999c5413ed2b339ccc58fb75143 100644
--- a/sdk/lib/svg/dart2js/svg_dart2js.dart
+++ b/sdk/lib/svg/dart2js/svg_dart2js.dart
@@ -3042,7 +3042,7 @@ class LengthList implements JavaScriptIndexingBehavior, List<Length> native "*SV
void forEach(void f(Length element)) => IterableMixinWorkaround.forEach(this, f);
- String join([String separator]) =>
+ String join([String separator = ""]) =>
IterableMixinWorkaround.joinList(this, separator);
Iterable map(f(Length element)) =>
@@ -3687,7 +3687,7 @@ class NumberList implements JavaScriptIndexingBehavior, List<Number> native "*SV
void forEach(void f(Number element)) => IterableMixinWorkaround.forEach(this, f);
- String join([String separator]) =>
+ String join([String separator = ""]) =>
IterableMixinWorkaround.joinList(this, separator);
Iterable map(f(Number element)) =>
@@ -4563,7 +4563,7 @@ class PathSegList implements JavaScriptIndexingBehavior, List<PathSeg> native "*
void forEach(void f(PathSeg element)) => IterableMixinWorkaround.forEach(this, f);
- String join([String separator]) =>
+ String join([String separator = ""]) =>
IterableMixinWorkaround.joinList(this, separator);
Iterable map(f(PathSeg element)) =>
@@ -5469,7 +5469,7 @@ class StringList implements JavaScriptIndexingBehavior, List<String> native "*SV
void forEach(void f(String element)) => IterableMixinWorkaround.forEach(this, f);
- String join([String separator]) =>
+ String join([String separator = ""]) =>
IterableMixinWorkaround.joinList(this, separator);
Iterable map(f(String element)) =>
@@ -6648,7 +6648,7 @@ class TransformList implements List<Transform>, JavaScriptIndexingBehavior nativ
void forEach(void f(Transform element)) => IterableMixinWorkaround.forEach(this, f);
- String join([String separator]) =>
+ String join([String separator = ""]) =>
IterableMixinWorkaround.joinList(this, separator);
Iterable map(f(Transform element)) =>
@@ -7186,7 +7186,7 @@ class _ElementInstanceList implements JavaScriptIndexingBehavior, List<ElementIn
void forEach(void f(ElementInstance element)) => IterableMixinWorkaround.forEach(this, f);
- String join([String separator]) =>
+ String join([String separator = ""]) =>
IterableMixinWorkaround.joinList(this, separator);
Iterable map(f(ElementInstance element)) =>
« no previous file with comments | « sdk/lib/io/io_sink.dart ('k') | sdk/lib/svg/dartium/svg_dartium.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698