Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1394343002: Remove "Search by Image" feature on Chrome for Android. (Closed)

Created:
5 years, 2 months ago by aurimas (slooooooooow)
Modified:
5 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@chrometab4
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove "Search by Image" feature on Chrome for Android. BUG=483685 Committed: https://crrev.com/ebf7da11adedc435768f9e3964dd91bf422a5e6f Cr-Commit-Position: refs/heads/master@{#353447}

Patch Set 1 #

Patch Set 2 : newt's nits #

Messages

Total messages: 17 (6 generated)
aurimas (slooooooooow)
PTAL
5 years, 2 months ago (2015-10-08 20:43:14 UTC) #2
newt (away)
Looks like there's a downstream test that needs to be removed (SearchByImageTest.java)
5 years, 2 months ago (2015-10-08 21:25:35 UTC) #3
newt (away)
Also delete IDS_CONTEXTMENU_SEARCH_WEB_FOR_IMAGE then lgtm
5 years, 2 months ago (2015-10-08 21:30:42 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1394343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1394343002/1
5 years, 2 months ago (2015-10-09 18:21:36 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/121696) win_chromium_compile_dbg_ng on ...
5 years, 2 months ago (2015-10-09 18:33:26 UTC) #8
aurimas (slooooooooow)
+mariakhomenko for chrome/browser/search_engines/* +jbudorick for build/android/*
5 years, 2 months ago (2015-10-09 23:12:59 UTC) #10
Maria
lgtm But kinda sad... I am one of those very few people who actually does ...
5 years, 2 months ago (2015-10-09 23:23:57 UTC) #11
jbudorick
build/android/ lgtm
5 years, 2 months ago (2015-10-09 23:25:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1394343002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1394343002/20001
5 years, 2 months ago (2015-10-09 23:35:55 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-10 01:08:21 UTC) #16
commit-bot: I haz the power
5 years, 2 months ago (2015-10-10 01:09:22 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ebf7da11adedc435768f9e3964dd91bf422a5e6f
Cr-Commit-Position: refs/heads/master@{#353447}

Powered by Google App Engine
This is Rietveld 408576698