Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1818)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

Issue 1394343002: Remove "Search by Image" feature on Chrome for Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@chrometab4
Patch Set: newt's nits Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
index d4191f4d3233978c1cbcc2ac4e8b5b597fea5f14..28614841b35e0c93c5797e61a03db97fc6dc6167 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
@@ -484,11 +484,6 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
mActivity.getTabModelSelector().openNewTab(loadUrlParams,
TabLaunchType.FROM_LONGPRESS_BACKGROUND, Tab.this, isIncognito());
}
-
- @Override
- public void onSearchByImageInNewTab() {
- triggerSearchByImage();
- }
}
private class TabContentViewClient extends ContentViewClient {
@@ -2687,13 +2682,6 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
}
/**
- * Triggers native search by image method.
- */
- public void triggerSearchByImage() {
- if (mNativeTabAndroid != 0) nativeSearchByImageInNewTabAsync(mNativeTabAndroid);
- }
-
- /**
* @return The ID of the bookmark associated with the current URL (or -1 if no such bookmark
* exists).
*/
@@ -3056,7 +3044,6 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
private native void nativeUpdateTopControlsState(
long nativeTabAndroid, int constraints, int current, boolean animate);
private native void nativeLoadOriginalImage(long nativeTabAndroid);
- private native void nativeSearchByImageInNewTabAsync(long nativeTabAndroid);
private native long nativeGetBookmarkId(long nativeTabAndroid, boolean onlyEditable);
private native boolean nativeHasOfflineCopy(long nativeTabAndroid);
private native boolean nativeIsOfflinePage(long nativeTabAndroid);

Powered by Google App Engine
This is Rietveld 408576698