Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1394303008: Remove unused Zone argument from InitializeAstVisitor (Closed)

Created:
5 years, 2 months ago by adamk
Modified:
5 years, 2 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove unused Zone argument from InitializeAstVisitor This adds a bit of boilerplate to some AstVisitors (they now have to declare their own zone_ member and zone() accessor), but makes it clearer what DEFINE_AST_VISITOR_SUBCLASS_MEMBERS is for: stack limit checking. Committed: https://crrev.com/4937cc9457aac003b71b59cfc7683b0c18836c6a Cr-Commit-Position: refs/heads/master@{#31287}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix AstExpressionVisitor #

Patch Set 3 : Fix build and AstTyper constructor #

Patch Set 4 : Fix cctests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -64 lines) Patch
M src/ast.h View 1 chunk +1 line, -4 lines 0 comments Download
M src/ast-expression-visitor.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/ast-expression-visitor.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/ast-numbering.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M src/codegen.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M src/compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ast-graph-builder.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/compiler/ast-graph-builder.cc View 6 chunks +6 lines, -8 lines 0 comments Download
M src/compiler/ast-loop-assignment-analyzer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ast-loop-assignment-analyzer.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/full-codegen/full-codegen.h View 3 chunks +6 lines, -1 line 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/interpreter/bytecode-generator.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/prettyprinter.h View 4 chunks +4 lines, -4 lines 0 comments Download
M src/prettyprinter.cc View 4 chunks +7 lines, -8 lines 0 comments Download
M src/rewriter.cc View 3 chunks +4 lines, -1 line 0 comments Download
M src/runtime/runtime-internal.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/typing.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/typing.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M src/typing-asm.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/typing-asm.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/typing-reset.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/typing-reset.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M test/cctest/expression-type-collector.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/expression-type-collector.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-asm-validator.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-ast-expression-visitor.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-typing-reset.cc View 1 2 3 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
adamk
Quick followup cleanup to the Isolate one (if you'd rather just keep the macro I'm ...
5 years, 2 months ago (2015-10-14 15:54:37 UTC) #2
Michael Starzinger
LGTM. https://codereview.chromium.org/1394303008/diff/1/src/ast-expression-visitor.cc File src/ast-expression-visitor.cc (right): https://codereview.chromium.org/1394303008/diff/1/src/ast-expression-visitor.cc#newcode35 src/ast-expression-visitor.cc:35: AstExpressionVisitor::AstExpressionVisitor(Isolate* isolate, Zone* zone, nit: Looks like the ...
5 years, 2 months ago (2015-10-15 07:58:51 UTC) #3
adamk
https://codereview.chromium.org/1394303008/diff/1/src/ast-expression-visitor.cc File src/ast-expression-visitor.cc (right): https://codereview.chromium.org/1394303008/diff/1/src/ast-expression-visitor.cc#newcode35 src/ast-expression-visitor.cc:35: AstExpressionVisitor::AstExpressionVisitor(Isolate* isolate, Zone* zone, On 2015/10/15 07:58:51, Michael Starzinger ...
5 years, 2 months ago (2015-10-15 08:03:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1394303008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1394303008/20001
5 years, 2 months ago (2015-10-15 08:04:08 UTC) #7
adamk
Hmm, cq bit maybe was a bit hasty, looks like I somehow caused crashes.
5 years, 2 months ago (2015-10-15 08:05:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1394303008/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1394303008/40001
5 years, 2 months ago (2015-10-15 08:23:23 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/10554) v8_mac_rel on tryserver.v8 (JOB_FAILED, ...
5 years, 2 months ago (2015-10-15 08:26:32 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1394303008/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1394303008/60001
5 years, 2 months ago (2015-10-15 09:50:42 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 2 months ago (2015-10-15 10:34:14 UTC) #18
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 10:34:38 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/4937cc9457aac003b71b59cfc7683b0c18836c6a
Cr-Commit-Position: refs/heads/master@{#31287}

Powered by Google App Engine
This is Rietveld 408576698