Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Side by Side Diff: src/compiler/ast-loop-assignment-analyzer.cc

Issue 1394303008: Remove unused Zone argument from InitializeAstVisitor (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix cctests Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/ast-loop-assignment-analyzer.h ('k') | src/full-codegen/full-codegen.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/ast-loop-assignment-analyzer.h" 5 #include "src/compiler/ast-loop-assignment-analyzer.h"
6 #include "src/compiler.h" 6 #include "src/compiler.h"
7 #include "src/parser.h" 7 #include "src/parser.h"
8 8
9 namespace v8 { 9 namespace v8 {
10 namespace internal { 10 namespace internal {
11 namespace compiler { 11 namespace compiler {
12 12
13 typedef class AstLoopAssignmentAnalyzer ALAA; // for code shortitude. 13 typedef class AstLoopAssignmentAnalyzer ALAA; // for code shortitude.
14 14
15 ALAA::AstLoopAssignmentAnalyzer(Zone* zone, CompilationInfo* info) 15 ALAA::AstLoopAssignmentAnalyzer(Zone* zone, CompilationInfo* info)
16 : info_(info), loop_stack_(zone) { 16 : info_(info), zone_(zone), loop_stack_(zone) {
17 InitializeAstVisitor(info->isolate(), zone); 17 InitializeAstVisitor(info->isolate());
18 } 18 }
19 19
20 20
21 LoopAssignmentAnalysis* ALAA::Analyze() { 21 LoopAssignmentAnalysis* ALAA::Analyze() {
22 LoopAssignmentAnalysis* a = new (zone()) LoopAssignmentAnalysis(zone()); 22 LoopAssignmentAnalysis* a = new (zone_) LoopAssignmentAnalysis(zone_);
23 result_ = a; 23 result_ = a;
24 VisitStatements(info()->literal()->body()); 24 VisitStatements(info()->literal()->body());
25 result_ = NULL; 25 result_ = NULL;
26 return a; 26 return a;
27 } 27 }
28 28
29 29
30 void ALAA::Enter(IterationStatement* loop) { 30 void ALAA::Enter(IterationStatement* loop) {
31 int num_variables = 1 + info()->scope()->num_parameters() + 31 int num_variables = 1 + info()->scope()->num_parameters() +
32 info()->scope()->num_stack_slots(); 32 info()->scope()->num_stack_slots();
33 BitVector* bits = new (zone()) BitVector(num_variables, zone()); 33 BitVector* bits = new (zone_) BitVector(num_variables, zone_);
34 if (info()->is_osr() && info()->osr_ast_id() == loop->OsrEntryId()) 34 if (info()->is_osr() && info()->osr_ast_id() == loop->OsrEntryId())
35 bits->AddAll(); 35 bits->AddAll();
36 loop_stack_.push_back(bits); 36 loop_stack_.push_back(bits);
37 } 37 }
38 38
39 39
40 void ALAA::Exit(IterationStatement* loop) { 40 void ALAA::Exit(IterationStatement* loop) {
41 DCHECK(loop_stack_.size() > 0); 41 DCHECK(loop_stack_.size() > 0);
42 BitVector* bits = loop_stack_.back(); 42 BitVector* bits = loop_stack_.back();
43 loop_stack_.pop_back(); 43 loop_stack_.pop_back();
(...skipping 254 matching lines...) Expand 10 before | Expand all | Expand 10 after
298 int count = 0; 298 int count = 0;
299 int var_index = AstLoopAssignmentAnalyzer::GetVariableIndex(scope, var); 299 int var_index = AstLoopAssignmentAnalyzer::GetVariableIndex(scope, var);
300 for (size_t i = 0; i < list_.size(); i++) { 300 for (size_t i = 0; i < list_.size(); i++) {
301 if (list_[i].second->Contains(var_index)) count++; 301 if (list_[i].second->Contains(var_index)) count++;
302 } 302 }
303 return count; 303 return count;
304 } 304 }
305 } // namespace compiler 305 } // namespace compiler
306 } // namespace internal 306 } // namespace internal
307 } // namespace v8 307 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/ast-loop-assignment-analyzer.h ('k') | src/full-codegen/full-codegen.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698