Issue 13942005: Add hit testing mode which ignores pointer-events:none.

Issue 13942005: Add hit testing mode which ignores pointer-events:none. (Closed)

Created:
7 years, 8 months ago by dgozman

Modified:
7 years, 8 months ago

Reviewers:
pfeldman, eseidel

CC:
blink-reviews, pdr, Stephen Chennney, f(malita), jchaffraix+rendering, carewolf

Base URL:
svn://svn.chromium.org/blink/trunk/

Visibility:
Public.

More Reviews

Description

Add hit testing mode which ignores pointer-events:none. Introduced new HitTestRequest::IgnorePointerEventsNone hit test type, which is used in special hit testing for Web Inspector, so user can inspect all the nodes. BUG=226955 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148465

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Patch Set 4 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -12 lines)			Patch
M	Source/WebCore/rendering/EllipsisBox.cpp	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebCore/rendering/HitTestRequest.h	View	1 2	2 chunks	+3 lines, -1 line	0 comments	Download
M	Source/WebCore/rendering/InlineBox.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
MM	Source/WebCore/rendering/InlineFlowBox.cpp	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebCore/rendering/InlineTextBox.cpp	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebCore/rendering/RenderBlock.cpp	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
MM	Source/WebCore/rendering/RenderBox.cpp	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebCore/rendering/RenderInline.cpp	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebCore/rendering/RenderObject.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/WebCore/rendering/RenderRegion.cpp	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
MM	Source/WebCore/rendering/RenderTable.cpp	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebCore/rendering/RootInlineBox.cpp	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebCore/rendering/svg/RenderSVGRoot.cpp	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

dgozman

Take a look, please. This was r+'ed by simon.fraser: https://bugs.webkit.org/show_bug.cgi?id=113042.

7 years, 8 months ago (2013-04-12 10:04:43 UTC) #1

pfeldman

https://codereview.chromium.org/13942005/diff/10001/Source/WebCore/rendering/RenderObject.h File Source/WebCore/rendering/RenderObject.h (right): https://codereview.chromium.org/13942005/diff/10001/Source/WebCore/rendering/RenderObject.h#newcode946 Source/WebCore/rendering/RenderObject.h:946: bool visibleToHitTestRequest(const HitTestRequest& request) const { return style()->visibility() == ...

7 years, 8 months ago (2013-04-12 14:45:43 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/13942005/10001

7 years, 8 months ago (2013-04-12 15:20:25 UTC) #4

commit-bot: I haz the power

Retried try job too often on mac_layout_rel for step(s) test_shell_tests, webkit_lint, webkit_tests, webkit_unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=1901

7 years, 8 months ago (2013-04-12 15:30:43 UTC) #5

dgozman

Committed patchset #4 manually as r148465 (presubmit successful).

7 years, 8 months ago (2013-04-16 15:11:21 UTC) #6

Message was sent while issue was closed.

Expand Messages | Collapse Messages