Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1394193002: Oilpan: tidy up some HeapVector<> uses. (Closed)

Created:
5 years, 2 months ago by sof
Modified:
5 years, 2 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: tidy up some HeapVector<> uses. Heap references should be wrapped up using Member: HeapVector<T*> => HeapVector<Member<T>> R=haraken BUG=515524 Committed: https://crrev.com/4fcf273efd262674241237e41ef06f687af5151b Cr-Commit-Position: refs/heads/master@{#353026}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M third_party/WebKit/Source/core/css/StylePropertySerializer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sof
please take a look.
5 years, 2 months ago (2015-10-08 09:03:08 UTC) #2
haraken
LGTM
5 years, 2 months ago (2015-10-08 09:03:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1394193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1394193002/1
5 years, 2 months ago (2015-10-08 09:47:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-08 10:04:05 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-08 10:04:53 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/4fcf273efd262674241237e41ef06f687af5151b
Cr-Commit-Position: refs/heads/master@{#353026}

Powered by Google App Engine
This is Rietveld 408576698