Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(991)

Unified Diff: third_party/WebKit/Source/core/css/StylePropertySerializer.cpp

Issue 1394193002: Oilpan: tidy up some HeapVector<> uses. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/input/EventHandler.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/StylePropertySerializer.cpp
diff --git a/third_party/WebKit/Source/core/css/StylePropertySerializer.cpp b/third_party/WebKit/Source/core/css/StylePropertySerializer.cpp
index 2ffe6bc7b3b13ea765c6f3dfa5d5101aa1c54d70..b40d7b90244694943f4b3cdb4b09ed7ae6c35521 100644
--- a/third_party/WebKit/Source/core/css/StylePropertySerializer.cpp
+++ b/third_party/WebKit/Source/core/css/StylePropertySerializer.cpp
@@ -609,7 +609,7 @@ String StylePropertySerializer::getLayeredShorthandValue(const StylePropertyShor
const unsigned size = shorthand.length();
// Begin by collecting the properties into a vector.
- WillBeHeapVector<const CSSValue*> values(size);
+ WillBeHeapVector<RawPtrWillBeMember<const CSSValue>> values(size);
// If the below loop succeeds, there should always be at minimum 1 layer.
size_t numLayers = 1U;
@@ -662,7 +662,7 @@ String StylePropertySerializer::getLayeredShorthandValue(const StylePropertyShor
ASSERT(shorthand.properties()[propertyIndex + 1] == CSSPropertyBackgroundRepeatY
|| shorthand.properties()[propertyIndex + 1] == CSSPropertyWebkitMaskRepeatY);
const CSSValue* yValue = values[propertyIndex + 1]->isValueList() ?
- toCSSValueList(values[propertyIndex + 1])->item(layer) : values[propertyIndex + 1];
+ toCSSValueList(values[propertyIndex + 1])->item(layer) : values[propertyIndex + 1].get();
// FIXME: At some point we need to fix this code to avoid returning an invalid shorthand,
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/input/EventHandler.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698