Issue 1394053003: Merge to XFA: Wean CJS_Value off of v8::Isolate.

Issue 1394053003: Merge to XFA: Wean CJS_Value off of v8::Isolate. (Closed)

Created:
5 years, 2 months ago by Tom Sepez

Modified:
5 years, 2 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Wean CJS_Value off of v8::Isolate. (cherry picked from commit 287b63d9ab410783d71cf37291f09fd57d3059b4) Original Review URL: https://codereview.chromium.org/1394103002 . R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/67fd5df1a378195ae3fb40c862a4e6e58731020a

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+382 lines, -495 lines)			Patch
M	fpdfsdk/src/javascript/Consts.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	fpdfsdk/src/javascript/Consts.cpp	View		8 chunks	+32 lines, -32 lines	0 comments	Download
M	fpdfsdk/src/javascript/Document.cpp	View	1	13 chunks	+33 lines, -47 lines	0 comments	Download
M	fpdfsdk/src/javascript/Field.cpp	View		27 chunks	+37 lines, -67 lines	0 comments	Download
M	fpdfsdk/src/javascript/JS_Define.h	View		8 chunks	+22 lines, -16 lines	0 comments	Download
M	fpdfsdk/src/javascript/JS_Runtime.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	fpdfsdk/src/javascript/JS_Runtime.cpp	View		2 chunks	+9 lines, -2 lines	0 comments	Download
M	fpdfsdk/src/javascript/JS_Value.h	View		7 chunks	+26 lines, -25 lines	0 comments	Download
M	fpdfsdk/src/javascript/JS_Value.cpp	View		21 chunks	+89 lines, -84 lines	0 comments	Download
M	fpdfsdk/src/javascript/PublicMethods.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	fpdfsdk/src/javascript/PublicMethods.cpp	View		24 chunks	+42 lines, -94 lines	0 comments	Download
M	fpdfsdk/src/javascript/app.cpp	View		12 chunks	+36 lines, -47 lines	0 comments	Download
M	fpdfsdk/src/javascript/color.cpp	View		8 chunks	+34 lines, -47 lines	0 comments	Download
M	fpdfsdk/src/javascript/global.h	View		2 chunks	+3 lines, -4 lines	0 comments	Download
M	fpdfsdk/src/javascript/global.cpp	View		6 chunks	+10 lines, -10 lines	0 comments	Download
M	fpdfsdk/src/javascript/util.cpp	View		4 chunks	+4 lines, -17 lines	0 comments	Download

Total messages: 7 (0 generated)

Tom Sepez

On 2015/10/08 19:13:07, Tom Sepez wrote: > Sorry, just one line in JS_Define.h:456. Bleh, and ...

5 years, 2 months ago (2015-10-08 19:14:16 UTC) #4

Tom Sepez

On 2015/10/08 19:14:16, Tom Sepez wrote: > On 2015/10/08 19:13:07, Tom Sepez wrote: > > ...

5 years, 2 months ago (2015-10-08 19:19:39 UTC) #5

Tom Sepez

5 years, 2 months ago (2015-10-08 19:24:24 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
67fd5df1a378195ae3fb40c862a4e6e58731020a (presubmit successful).