Wean CJS_Value off of v8::Isolate.

Wean CJS_Value off of v8::Isolate.

CJS_Values should belong to CJS_Runtimes so that we may
eventually cram much of the v8 dependencies down into fxjs.

This is a first step; the remaining split in this code between
isolate and CJS_Runtime goes away when fxjs provides a CFXJS_Runtime
object, and the CJS_Runtime is-a/has-a CFXJS_Runtime. But that can't
happen until this is resolved.

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/287b63d9ab410783d71cf37291f09fd57d3059b4

[Tom Sepez, 2015-10-07 23:06:22]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2015-10-07 23:06:23]

Lei, first step.

https://codereview.chromium.org/1394103002/diff/1/fpdfsdk/src/javascript/Cons...
File fpdfsdk/src/javascript/Consts.cpp (right):

https://codereview.chromium.org/1394103002/diff/1/fpdfsdk/src/javascript/Cons...
fpdfsdk/src/javascript/Consts.cpp:135:
FXJS_DefineGlobalConst(pRuntime->GetIsolate(), pConstName,
i.e. down the road, when FXJS provides an object, things like this become:
  CFXJS_Runtime* pFXJSRuntime = pRuntime->GetFXJSRuntime();
  pFXRuntime->DefineGlobalConst(pConstName, pFXRuntime->NewString(pValue));

for the has-a case, or just
  pRuntime->DefineGlobalConst(pConstName, pRuntime->NewString(pValue));

for the is-a case. So when you see isolate, remember that it goes away mostly. 
It's saner this way, because a CFXJS_Runtime will include a v8::Context as well,
so a lot of the manipulations get smaller.

[Lei Zhang, 2015-10-08 05:40:51]

lgtm

https://codereview.chromium.org/1394103002/diff/1/fpdfsdk/src/javascript/Docu...
File fpdfsdk/src/javascript/Document.cpp (right):

https://codereview.chromium.org/1394103002/diff/1/fpdfsdk/src/javascript/Docu...
fpdfsdk/src/javascript/Document.cpp:1387: CJS_Context* pContext =
static_cast<CJS_Context*>(cc);
Just move this 1 level up and remove the same var below?

[Tom Sepez, 2015-10-08 19:04:44]

Committed patchset #1 (id:1) manually as
287b63d9ab410783d71cf37291f09fd57d3059b4 (presubmit successful).