Issue 1394023002: Merge to XFA: Remove unused global argument from FXJS_CONSTRUCTOR.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1394023002: Merge to XFA: Remove unused global argument from FXJS_CONSTRUCTOR. (Closed)

Created:
5 years, 2 months ago by Tom Sepez

Modified:
5 years, 2 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Remove unused global argument from FXJS_CONSTRUCTOR. (cherry picked from commit ebd39a6a8fcbbbf1c5a2e6f1b2e30f452971d0ee) Original Review URL: https://codereview.chromium.org/1389003003 . TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/7fed2e7b5df7897abf365745ad688aab4bdfdf5a

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -20 lines)			Patch
M	fpdfsdk/include/jsapi/fxjs_v8.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	fpdfsdk/src/javascript/JS_Define.h	View	1 chunk	+7 lines, -9 lines	0 comments	Download
M	fpdfsdk/src/jsapi/fxjs_v8.cpp	View	2 chunks	+2 lines, -8 lines	0 comments	Download

Total messages: 3 (0 generated)

Tom Sepez

Committed patchset #1 (id:1) manually as 7fed2e7b5df7897abf365745ad688aab4bdfdf5a (presubmit successful).

5 years, 2 months ago (2015-10-07 20:09:41 UTC) #2

Message was sent while issue was closed.

lgtm