Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 1389003003: Remove unused global argument from FXJS_CONSTRUCTOR. (Closed)

Created:
5 years, 2 months ago by Tom Sepez
Modified:
5 years, 2 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -22 lines) Patch
M fpdfsdk/include/jsapi/fxjs_v8.h View 1 chunk +1 line, -3 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Define.h View 1 chunk +7 lines, -9 lines 0 comments Download
M fpdfsdk/src/jsapi/fxjs_v8.cpp View 2 chunks +3 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
Lei, only deletions.
5 years, 2 months ago (2015-10-06 18:32:38 UTC) #2
Lei Zhang
lgtm
5 years, 2 months ago (2015-10-06 18:44:39 UTC) #3
Tom Sepez
5 years, 2 months ago (2015-10-06 18:47:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ebd39a6a8fcbbbf1c5a2e6f1b2e30f452971d0ee (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698